diff --git a/src/com/android/settings/homepage/contextualcards/ContextualCardLoader.java b/src/com/android/settings/homepage/contextualcards/ContextualCardLoader.java index d30fe59a51d..e4a644cf780 100644 --- a/src/com/android/settings/homepage/contextualcards/ContextualCardLoader.java +++ b/src/com/android/settings/homepage/contextualcards/ContextualCardLoader.java @@ -184,6 +184,10 @@ public class ContextualCardLoader extends AsyncLoaderCompat @VisibleForTesting List filterEligibleCards(List candidates) { + if (candidates.isEmpty()) { + return candidates; + } + final ExecutorService executor = Executors.newFixedThreadPool(candidates.size()); final List cards = new ArrayList<>(); List> eligibleCards = new ArrayList<>(); diff --git a/tests/robotests/src/com/android/settings/slices/SettingsSliceProviderTest.java b/tests/robotests/src/com/android/settings/slices/SettingsSliceProviderTest.java index 0fa249d8fb7..2f0d60aaf97 100644 --- a/tests/robotests/src/com/android/settings/slices/SettingsSliceProviderTest.java +++ b/tests/robotests/src/com/android/settings/slices/SettingsSliceProviderTest.java @@ -270,23 +270,27 @@ public class SettingsSliceProviderTest { @Test public void onBindSlice_nightModeChanged_shouldReloadTheme() { - mContext.getResources().getConfiguration().uiMode = UI_MODE_NIGHT_YES; - + mContext.getResources().getConfiguration().uiMode = UI_MODE_NIGHT_NO; final SliceData data = getDummyData(); mProvider.mSliceWeakDataCache.put(data.getUri(), data); mProvider.onBindSlice(data.getUri()); + mContext.getResources().getConfiguration().uiMode = UI_MODE_NIGHT_YES; + mProvider.onBindSlice(data.getUri()); + assertThat(ShadowTheme.isThemeRebased()).isTrue(); } @Test public void onBindSlice_nightModeNotChanged_shouldNotReloadTheme() { mContext.getResources().getConfiguration().uiMode = UI_MODE_NIGHT_NO; - SliceData data = getDummyData(); mProvider.mSliceWeakDataCache.put(data.getUri(), data); mProvider.onBindSlice(data.getUri()); + mContext.getResources().getConfiguration().uiMode = UI_MODE_NIGHT_NO; + mProvider.onBindSlice(data.getUri()); + assertThat(ShadowTheme.isThemeRebased()).isFalse(); }