From 1605b0364ce98ff1795b8380474237ef1d89518f Mon Sep 17 00:00:00 2001 From: hughchen Date: Tue, 15 Oct 2019 17:27:13 +0800 Subject: [PATCH] Fix Connected devices page UI not update after paired This CL before, onChanged(null) will cause PreferenceGroup didn't update UI in ConnectedDeviceDashboardFragment. This CL remove onChanged(null) and set unvisible of SliceView in the constructor. Bug: 142220754 Test: make -j42 RunSettingsRoboTests Change-Id: Ib20db373430589c5c5efbe8a4c866b7fae4f3399 --- src/com/android/settings/slices/SlicePreference.java | 1 + .../android/settings/slices/SlicePreferenceController.java | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/com/android/settings/slices/SlicePreference.java b/src/com/android/settings/slices/SlicePreference.java index a2a7fe173fa..fe5ed60737d 100644 --- a/src/com/android/settings/slices/SlicePreference.java +++ b/src/com/android/settings/slices/SlicePreference.java @@ -46,6 +46,7 @@ public class SlicePreference extends LayoutPreference { mSliceView = findViewById(R.id.slice_view); mSliceView.setShowTitleItems(true); mSliceView.setScrollable(false); + mSliceView.setVisibility(View.GONE); } public void onSliceUpdated(Slice slice) { diff --git a/src/com/android/settings/slices/SlicePreferenceController.java b/src/com/android/settings/slices/SlicePreferenceController.java index c31321d9c4b..df28304f738 100644 --- a/src/com/android/settings/slices/SlicePreferenceController.java +++ b/src/com/android/settings/slices/SlicePreferenceController.java @@ -32,7 +32,6 @@ import com.android.settings.core.BasePreferenceController; import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.core.lifecycle.events.OnStop; -import com.android.settingslib.utils.ThreadUtils; /** * Default {@link BasePreferenceController} for {@link SliceView}. It will take {@link Uri} for @@ -66,9 +65,6 @@ public class SlicePreferenceController extends BasePreferenceController implemen mUri = uri; mLiveData = SliceLiveData.fromUri(mContext, mUri, (int type, Throwable source) -> { Log.w(TAG, "Slice may be null. uri = " + uri + ", error = " + type); - ThreadUtils.postOnMainThread(() -> { - onChanged(null); - }); }); //TODO(b/120803703): figure out why we need to remove observer first