Remove the current battery usage chart and replace it with new one
Bug: 183921876 Test: make SettingsRoboTests Test: make SettingsGoogleRoboTests Change-Id: I06f0eb5c09d07a9db0d1a93cda751e8fad672c79
This commit is contained in:
@@ -95,6 +95,7 @@ public class BatteryChartView extends AppCompatImageView implements View.OnClick
|
||||
public void setLevels(int[] levels) {
|
||||
// We should provide trapezoid count + 1 data to draw all trapezoids.
|
||||
mLevels = levels.length == mTrapezoidCount + 1 ? levels : null;
|
||||
setClickable(mLevels != null);
|
||||
invalidate();
|
||||
}
|
||||
|
||||
|
||||
@@ -19,8 +19,8 @@ package com.android.settings.fuelgauge;
|
||||
import android.content.Context;
|
||||
import android.os.BatteryUsageStats;
|
||||
import android.util.AttributeSet;
|
||||
import android.util.Log;
|
||||
import android.view.View;
|
||||
import android.widget.TextView;
|
||||
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.VisibleForTesting;
|
||||
@@ -28,26 +28,26 @@ import androidx.preference.Preference;
|
||||
import androidx.preference.PreferenceViewHolder;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.widget.UsageView;
|
||||
import com.android.settings.overlay.FeatureFactory;
|
||||
|
||||
/**
|
||||
* Custom preference for displaying power consumption as a bar and an icon on the left for the
|
||||
* subsystem/app type.
|
||||
* Custom preference for displaying the battery level as chart graph.
|
||||
*/
|
||||
public class BatteryHistoryPreference extends Preference {
|
||||
private static final String TAG = "BatteryHistoryPreference";
|
||||
|
||||
private CharSequence mSummary;
|
||||
private TextView mSummaryView;
|
||||
|
||||
@VisibleForTesting
|
||||
boolean hideSummary;
|
||||
@VisibleForTesting
|
||||
BatteryInfo mBatteryInfo;
|
||||
|
||||
public BatteryHistoryPreference(Context context, AttributeSet attrs) {
|
||||
super(context, attrs);
|
||||
setLayoutResource(R.layout.battery_usage_graph);
|
||||
final boolean isChartGraphEnabled =
|
||||
FeatureFactory.getFactory(context).getPowerUsageFeatureProvider(context)
|
||||
.isChartGraphEnabled(context);
|
||||
Log.i(TAG, "isChartGraphEnabled: " + isChartGraphEnabled);
|
||||
if (isChartGraphEnabled) {
|
||||
setLayoutResource(R.layout.battery_chart_graph);
|
||||
}
|
||||
setSelectable(false);
|
||||
}
|
||||
|
||||
@@ -58,22 +58,6 @@ public class BatteryHistoryPreference extends Preference {
|
||||
}, batteryUsageStats, false);
|
||||
}
|
||||
|
||||
public void setBottomSummary(CharSequence text) {
|
||||
mSummary = text;
|
||||
if (mSummaryView != null) {
|
||||
mSummaryView.setVisibility(View.VISIBLE);
|
||||
mSummaryView.setText(mSummary);
|
||||
}
|
||||
hideSummary = false;
|
||||
}
|
||||
|
||||
public void hideBottomSummary() {
|
||||
if (mSummaryView != null) {
|
||||
mSummaryView.setVisibility(View.GONE);
|
||||
}
|
||||
hideSummary = true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onBindViewHolder(PreferenceViewHolder view) {
|
||||
super.onBindViewHolder(view);
|
||||
@@ -81,18 +65,6 @@ public class BatteryHistoryPreference extends Preference {
|
||||
if (mBatteryInfo == null) {
|
||||
return;
|
||||
}
|
||||
|
||||
((TextView) view.findViewById(R.id.charge)).setText(mBatteryInfo.batteryPercentString);
|
||||
mSummaryView = (TextView) view.findViewById(R.id.bottom_summary);
|
||||
if (mSummary != null) {
|
||||
mSummaryView.setText(mSummary);
|
||||
}
|
||||
if (hideSummary) {
|
||||
mSummaryView.setVisibility(View.GONE);
|
||||
}
|
||||
UsageView usageView = (UsageView) view.findViewById(R.id.battery_usage);
|
||||
usageView.findViewById(R.id.label_group).setAlpha(.7f);
|
||||
mBatteryInfo.bindHistory(usageView);
|
||||
BatteryUtils.logRuntime(TAG, "onBindViewHolder", startTime);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -63,9 +63,6 @@ public class PowerUsageAdvanced extends PowerUsageBase {
|
||||
mHistPref = (BatteryHistoryPreference) findPreference(KEY_BATTERY_GRAPH);
|
||||
mPowerUsageFeatureProvider = FeatureFactory.getFactory(context)
|
||||
.getPowerUsageFeatureProvider(context);
|
||||
|
||||
// init the summary so other preferences won't have unnecessary move
|
||||
updateHistPrefSummary(context);
|
||||
restoreSavedInstance(icicle);
|
||||
}
|
||||
|
||||
@@ -151,24 +148,9 @@ public class PowerUsageAdvanced extends PowerUsageBase {
|
||||
return;
|
||||
}
|
||||
updatePreference(mHistPref);
|
||||
updateHistPrefSummary(context);
|
||||
|
||||
mBatteryAppListPreferenceController.refreshAppListGroup(mBatteryUsageStats, mShowAllApps);
|
||||
}
|
||||
|
||||
private void updateHistPrefSummary(Context context) {
|
||||
Intent batteryIntent =
|
||||
context.registerReceiver(null, new IntentFilter(Intent.ACTION_BATTERY_CHANGED));
|
||||
final boolean plugged = batteryIntent.getIntExtra(BatteryManager.EXTRA_PLUGGED, -1) != 0;
|
||||
|
||||
if (mPowerUsageFeatureProvider.isEnhancedBatteryPredictionEnabled(context) && !plugged) {
|
||||
mHistPref.setBottomSummary(
|
||||
mPowerUsageFeatureProvider.getAdvancedUsageScreenInfoString());
|
||||
} else {
|
||||
mHistPref.hideBottomSummary();
|
||||
}
|
||||
}
|
||||
|
||||
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
|
||||
new BaseSearchIndexProvider() {
|
||||
@Override
|
||||
|
||||
@@ -124,4 +124,9 @@ public interface PowerUsageFeatureProvider {
|
||||
* Checks whether smart battery feature is supported in this device
|
||||
*/
|
||||
boolean isSmartBatterySupported();
|
||||
|
||||
/**
|
||||
* Checks whether we should enable chart graph design or not
|
||||
*/
|
||||
boolean isChartGraphEnabled(Context context);
|
||||
}
|
||||
|
||||
@@ -150,4 +150,9 @@ public class PowerUsageFeatureProviderImpl implements PowerUsageFeatureProvider
|
||||
return mContext.getResources().getBoolean(
|
||||
com.android.internal.R.bool.config_smart_battery_available);
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isChartGraphEnabled(Context context) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user