diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 386f0c2edc2..f07c39f0f94 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -1896,11 +1896,13 @@ android:icon="@drawable/ic_settings_development" android:taskAffinity="com.android.settings" android:parentActivityName="Settings"> + @@ -1919,14 +1921,11 @@ android:icon="@drawable/ic_settings_development" android:taskAffinity="com.android.settings" android:parentActivityName="Settings"> - - @@ -1994,9 +1993,9 @@ + android:targetActivity="Settings$DevelopmentSettingsDashboardActivity"> + android:value="com.android.settings.development.DevelopmentSettingsDashboardFragment" /> + android:targetActivity="Settings$DevelopmentSettingsDashboardActivity"> diff --git a/src/com/android/settings/Settings.java b/src/com/android/settings/Settings.java index 2377ca5bc3b..eac38015312 100644 --- a/src/com/android/settings/Settings.java +++ b/src/com/android/settings/Settings.java @@ -73,12 +73,12 @@ public class Settings extends SettingsActivity { * @deprecated in favor of {@link DevelopmentSettingsDashboardActivity}. */ @Deprecated - public static class DevelopmentSettingsActivity extends SettingsActivity { /* empty */ } - public static class DevelopmentSettingsDashboardActivity extends SettingsActivity { + public static class DevelopmentSettingsActivity extends SettingsActivity { public static final boolean isEnabled() { - return FeatureFlagUtils.isEnabled("dev_option_v2"); + return FeatureFlagUtils.isEnabled("dev_option_v1"); } } + public static class DevelopmentSettingsDashboardActivity extends SettingsActivity { /* empty */ } public static class AccessibilitySettingsActivity extends SettingsActivity { /* empty */ } public static class CaptioningSettingsActivity extends SettingsActivity { /* empty */ } public static class AccessibilityInversionSettingsActivity extends SettingsActivity { /* empty */ } diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index 973c216231b..1202d1301af 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -832,16 +832,16 @@ public class SettingsActivity extends SettingsDrawerActivity final boolean showDev = DevelopmentSettingsEnabler.isDevelopmentSettingsEnabled(this) && !um.hasUserRestriction(UserManager.DISALLOW_DEBUGGING_FEATURES); - final boolean useDevOptionV2 = Settings.DevelopmentSettingsDashboardActivity.isEnabled(); + final boolean useDevOptionV1 = Settings.DevelopmentSettingsActivity.isEnabled(); // Enable old Dev option if v2 is disabled somethingChanged = setTileEnabled(new ComponentName(packageName, Settings.DevelopmentSettingsActivity.class.getName()), - showDev && !useDevOptionV2, isAdmin) + showDev && useDevOptionV1, isAdmin) || somethingChanged; // Enable new Dev option if v2 is enable somethingChanged = setTileEnabled(new ComponentName(packageName, Settings.DevelopmentSettingsDashboardActivity.class.getName()), - showDev && useDevOptionV2, isAdmin) + showDev && !useDevOptionV1, isAdmin) || somethingChanged; // Enable/disable backup settings depending on whether the user is admin. diff --git a/src/com/android/settings/bluetooth/DeviceListPreferenceFragment.java b/src/com/android/settings/bluetooth/DeviceListPreferenceFragment.java index 0485e69628b..9d47c65c843 100644 --- a/src/com/android/settings/bluetooth/DeviceListPreferenceFragment.java +++ b/src/com/android/settings/bluetooth/DeviceListPreferenceFragment.java @@ -53,7 +53,7 @@ public abstract class DeviceListPreferenceFragment extends private static final String KEY_BT_SCAN = "bt_scan"; - // Copied from DevelopmentSettings.java + // Copied from BluetoothDeviceNoNamePreferenceController.java private static final String BLUETOOTH_SHOW_DEVICES_WITHOUT_NAMES_PROPERTY = "persist.bluetooth.showdeviceswithoutnames"; diff --git a/src/com/android/settings/dashboard/DashboardFragmentRegistry.java b/src/com/android/settings/dashboard/DashboardFragmentRegistry.java index 17e556e1946..07448620b61 100644 --- a/src/com/android/settings/dashboard/DashboardFragmentRegistry.java +++ b/src/com/android/settings/dashboard/DashboardFragmentRegistry.java @@ -85,11 +85,11 @@ public class DashboardFragmentRegistry { SystemDashboardFragment.class.getName(), CategoryKey.CATEGORY_SYSTEM); PARENT_TO_CATEGORY_KEY_MAP.put(LanguageAndInputSettings.class.getName(), CategoryKey.CATEGORY_SYSTEM_LANGUAGE); - if (Settings.DevelopmentSettingsDashboardActivity.isEnabled()) { - PARENT_TO_CATEGORY_KEY_MAP.put(DevelopmentSettingsDashboardFragment.class.getName(), + if (Settings.DevelopmentSettingsActivity.isEnabled()) { + PARENT_TO_CATEGORY_KEY_MAP.put(DevelopmentSettings.class.getName(), CategoryKey.CATEGORY_SYSTEM_DEVELOPMENT); } else { - PARENT_TO_CATEGORY_KEY_MAP.put(DevelopmentSettings.class.getName(), + PARENT_TO_CATEGORY_KEY_MAP.put(DevelopmentSettingsDashboardFragment.class.getName(), CategoryKey.CATEGORY_SYSTEM_DEVELOPMENT); } PARENT_TO_CATEGORY_KEY_MAP.put(ConfigureNotificationSettings.class.getName(), diff --git a/src/com/android/settings/deviceinfo/BuildNumberPreferenceController.java b/src/com/android/settings/deviceinfo/BuildNumberPreferenceController.java index ac318ff3b0e..2641f5d941f 100644 --- a/src/com/android/settings/deviceinfo/BuildNumberPreferenceController.java +++ b/src/com/android/settings/deviceinfo/BuildNumberPreferenceController.java @@ -35,7 +35,6 @@ import com.android.settings.R; import com.android.settings.Utils; import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.instrumentation.MetricsFeatureProvider; -import com.android.settings.development.DevelopmentSettings; import com.android.settings.overlay.FeatureFactory; import com.android.settings.password.ChooseLockSettingsHelper; import com.android.settingslib.RestrictedLockUtils; @@ -221,9 +220,5 @@ public class BuildNumberPreferenceController extends AbstractPreferenceControlle mDevHitToast = Toast.makeText(mContext, R.string.show_dev_on, Toast.LENGTH_LONG); mDevHitToast.show(); - // This is good time to index the Developer Options - FeatureFactory.getFactory(mContext).getSearchFeatureProvider().getIndexingManager(mContext) - .updateFromClassNameResource(DevelopmentSettings.class.getName(), - true /* includeInSearchResults */); } } diff --git a/src/com/android/settings/search/SearchIndexableResources.java b/src/com/android/settings/search/SearchIndexableResources.java index 9608aea5920..1774615fbbd 100644 --- a/src/com/android/settings/search/SearchIndexableResources.java +++ b/src/com/android/settings/search/SearchIndexableResources.java @@ -21,6 +21,7 @@ import android.support.annotation.DrawableRes; import android.support.annotation.VisibleForTesting; import android.support.annotation.XmlRes; import android.text.TextUtils; + import com.android.settings.DateTimeSettings; import com.android.settings.DeviceInfoSettings; import com.android.settings.DisplaySettings; @@ -45,7 +46,7 @@ import com.android.settings.datausage.DataPlanUsageSummary; import com.android.settings.datausage.DataUsageMeteredSettings; import com.android.settings.datausage.DataUsageSummary; import com.android.settings.deletionhelper.AutomaticStorageManagerSettings; -import com.android.settings.development.DevelopmentSettings; +import com.android.settings.development.DevelopmentSettingsDashboardFragment; import com.android.settings.deviceinfo.Status; import com.android.settings.deviceinfo.StorageDashboardFragment; import com.android.settings.deviceinfo.StorageSettings; @@ -90,6 +91,7 @@ import com.android.settings.wallpaper.WallpaperTypeSettings; import com.android.settings.wifi.ConfigureWifiSettings; import com.android.settings.wifi.SavedAccessPointsWifiSettings; import com.android.settings.wifi.WifiSettings; + import java.util.Collection; import java.util.HashMap; @@ -189,7 +191,8 @@ public final class SearchIndexableResources { addIndex(DateTimeSettings.class, NO_DATA_RES_ID, R.drawable.ic_settings_date_time); addIndex(AccessibilitySettings.class, NO_DATA_RES_ID, R.drawable.ic_settings_accessibility); addIndex(PrintSettingsFragment.class, NO_DATA_RES_ID, R.drawable.ic_settings_print); - addIndex(DevelopmentSettings.class, NO_DATA_RES_ID, R.drawable.ic_settings_development); + addIndex(DevelopmentSettingsDashboardFragment.class, NO_DATA_RES_ID, + R.drawable.ic_settings_development); addIndex(DeviceInfoSettings.class, NO_DATA_RES_ID, R.drawable.ic_settings_about); addIndex(Status.class, NO_DATA_RES_ID, 0 /* icon */); addIndex(LegalSettings.class, NO_DATA_RES_ID, R.drawable.ic_settings_about); diff --git a/tests/robotests/assets/grandfather_not_in_search_index_provider_registry b/tests/robotests/assets/grandfather_not_in_search_index_provider_registry index 4ee97fa5fc7..85e99c3fc74 100644 --- a/tests/robotests/assets/grandfather_not_in_search_index_provider_registry +++ b/tests/robotests/assets/grandfather_not_in_search_index_provider_registry @@ -1,3 +1,3 @@ -com.android.settings.development.DevelopmentSettingsDashboardFragment +com.android.settings.development.DevelopmentSettings com.android.settings.display.ScreenZoomPreferenceFragmentForSetupWizard com.android.settings.search.indexing.FakeSettingsFragment