Stop showing account based cards in homepage.
Removed data usage/device info/emergency/storage cards Bug: 118691898 Test: robotests Change-Id: I9f1ef3f022be9ca37e3359a6820a716d4ebade0f
This commit is contained in:
@@ -33,8 +33,6 @@ import androidx.annotation.VisibleForTesting;
|
|||||||
import androidx.slice.Slice;
|
import androidx.slice.Slice;
|
||||||
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DataUsageSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DeviceInfoSlice;
|
|
||||||
import com.android.settingslib.utils.AsyncLoaderCompat;
|
import com.android.settingslib.utils.AsyncLoaderCompat;
|
||||||
|
|
||||||
import java.util.ArrayList;
|
import java.util.ArrayList;
|
||||||
@@ -93,15 +91,6 @@ public class ContextualCardLoader extends AsyncLoaderCompat<List<ContextualCard>
|
|||||||
final String packageName = mContext.getPackageName();
|
final String packageName = mContext.getPackageName();
|
||||||
final double rankingScore = 0.0;
|
final double rankingScore = 0.0;
|
||||||
final List<ContextualCard> result = new ArrayList();
|
final List<ContextualCard> result = new ArrayList();
|
||||||
result.add(new ContextualCard.Builder()
|
|
||||||
.setSliceUri(DataUsageSlice.DATA_USAGE_CARD_URI)
|
|
||||||
.setName(DataUsageSlice.PATH_DATA_USAGE)
|
|
||||||
.setPackageName(packageName)
|
|
||||||
.setRankingScore(rankingScore)
|
|
||||||
.setAppVersion(appVersionCode)
|
|
||||||
.setCardType(ContextualCard.CardType.SLICE)
|
|
||||||
.setIsHalfWidth(false)
|
|
||||||
.build());
|
|
||||||
result.add(new ContextualCard.Builder()
|
result.add(new ContextualCard.Builder()
|
||||||
.setSliceUri(BatterySlice.BATTERY_CARD_URI)
|
.setSliceUri(BatterySlice.BATTERY_CARD_URI)
|
||||||
.setName(BatterySlice.PATH_BATTERY_INFO)
|
.setName(BatterySlice.PATH_BATTERY_INFO)
|
||||||
@@ -111,15 +100,6 @@ public class ContextualCardLoader extends AsyncLoaderCompat<List<ContextualCard>
|
|||||||
.setCardType(ContextualCard.CardType.SLICE)
|
.setCardType(ContextualCard.CardType.SLICE)
|
||||||
.setIsHalfWidth(false)
|
.setIsHalfWidth(false)
|
||||||
.build());
|
.build());
|
||||||
result.add(new ContextualCard.Builder()
|
|
||||||
.setSliceUri(DeviceInfoSlice.DEVICE_INFO_CARD_URI)
|
|
||||||
.setName(DeviceInfoSlice.PATH_DEVICE_INFO)
|
|
||||||
.setPackageName(packageName)
|
|
||||||
.setRankingScore(rankingScore)
|
|
||||||
.setAppVersion(appVersionCode)
|
|
||||||
.setCardType(ContextualCard.CardType.SLICE)
|
|
||||||
.setIsHalfWidth(false)
|
|
||||||
.build());
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -21,10 +21,6 @@ import static android.provider.SettingsSlicesContract.KEY_WIFI;
|
|||||||
import android.annotation.Nullable;
|
import android.annotation.Nullable;
|
||||||
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DataUsageSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DeviceInfoSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.EmergencyInfoSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.StorageSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.slices.ConnectedDeviceSlice;
|
import com.android.settings.homepage.contextualcards.slices.ConnectedDeviceSlice;
|
||||||
import com.android.settings.intelligence.ContextualCardProto.ContextualCard;
|
import com.android.settings.intelligence.ContextualCardProto.ContextualCard;
|
||||||
import com.android.settings.intelligence.ContextualCardProto.ContextualCardList;
|
import com.android.settings.intelligence.ContextualCardProto.ContextualCardList;
|
||||||
@@ -45,26 +41,6 @@ public class SettingsContextualCardProvider extends ContextualCardProvider {
|
|||||||
.setSliceUri(WifiSlice.WIFI_URI.toString())
|
.setSliceUri(WifiSlice.WIFI_URI.toString())
|
||||||
.setCardName(KEY_WIFI)
|
.setCardName(KEY_WIFI)
|
||||||
.build();
|
.build();
|
||||||
final ContextualCard dataUsageCard =
|
|
||||||
ContextualCard.newBuilder()
|
|
||||||
.setSliceUri(DataUsageSlice.DATA_USAGE_CARD_URI.toString())
|
|
||||||
.setCardName(DataUsageSlice.PATH_DATA_USAGE)
|
|
||||||
.build();
|
|
||||||
final ContextualCard deviceInfoCard =
|
|
||||||
ContextualCard.newBuilder()
|
|
||||||
.setSliceUri(DeviceInfoSlice.DEVICE_INFO_CARD_URI.toString())
|
|
||||||
.setCardName(DeviceInfoSlice.PATH_DEVICE_INFO)
|
|
||||||
.build();
|
|
||||||
final ContextualCard storageInfoCard =
|
|
||||||
ContextualCard.newBuilder()
|
|
||||||
.setSliceUri(StorageSlice.STORAGE_CARD_URI.toString())
|
|
||||||
.setCardName(StorageSlice.PATH_STORAGE_INFO)
|
|
||||||
.build();
|
|
||||||
final ContextualCard emergencyInfoCard =
|
|
||||||
ContextualCard.newBuilder()
|
|
||||||
.setSliceUri(EmergencyInfoSlice.EMERGENCY_INFO_CARD_URI.toString())
|
|
||||||
.setCardName(EmergencyInfoSlice.PATH_EMERGENCY_INFO_CARD)
|
|
||||||
.build();
|
|
||||||
final ContextualCard batteryInfoCard =
|
final ContextualCard batteryInfoCard =
|
||||||
ContextualCard.newBuilder()
|
ContextualCard.newBuilder()
|
||||||
.setSliceUri(BatterySlice.BATTERY_CARD_URI.toSafeString())
|
.setSliceUri(BatterySlice.BATTERY_CARD_URI.toSafeString())
|
||||||
@@ -77,10 +53,6 @@ public class SettingsContextualCardProvider extends ContextualCardProvider {
|
|||||||
.build();
|
.build();
|
||||||
final ContextualCardList cards = ContextualCardList.newBuilder()
|
final ContextualCardList cards = ContextualCardList.newBuilder()
|
||||||
.addCard(wifiCard)
|
.addCard(wifiCard)
|
||||||
.addCard(dataUsageCard)
|
|
||||||
.addCard(deviceInfoCard)
|
|
||||||
.addCard(storageInfoCard)
|
|
||||||
.addCard(emergencyInfoCard)
|
|
||||||
.addCard(batteryInfoCard)
|
.addCard(batteryInfoCard)
|
||||||
.addCard(connectedDeviceCard)
|
.addCard(connectedDeviceCard)
|
||||||
.build();
|
.build();
|
||||||
|
@@ -22,8 +22,6 @@ import android.content.Context;
|
|||||||
import android.net.Uri;
|
import android.net.Uri;
|
||||||
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
import com.android.settings.homepage.contextualcards.deviceinfo.BatterySlice;
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DataUsageSlice;
|
|
||||||
import com.android.settings.homepage.contextualcards.deviceinfo.DeviceInfoSlice;
|
|
||||||
import com.android.settings.slices.SettingsSliceProvider;
|
import com.android.settings.slices.SettingsSliceProvider;
|
||||||
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
||||||
|
|
||||||
@@ -53,19 +51,10 @@ public class ContextualCardLoaderTest {
|
|||||||
mProvider);
|
mProvider);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
|
||||||
public void createStaticCards_shouldReturnFourCards() {
|
|
||||||
final List<ContextualCard> defaultData = mContextualCardLoader.createStaticCards();
|
|
||||||
|
|
||||||
assertThat(defaultData).hasSize(3);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void createStaticCards_shouldContainCorrectCards() {
|
public void createStaticCards_shouldContainCorrectCards() {
|
||||||
final Uri dataUsage = DataUsageSlice.DATA_USAGE_CARD_URI;
|
|
||||||
final Uri deviceInfo = DeviceInfoSlice.DEVICE_INFO_CARD_URI;
|
|
||||||
final Uri batteryInfo = BatterySlice.BATTERY_CARD_URI;
|
final Uri batteryInfo = BatterySlice.BATTERY_CARD_URI;
|
||||||
final List<Uri> expectedUris = Arrays.asList(dataUsage, deviceInfo, batteryInfo);
|
final List<Uri> expectedUris = Arrays.asList(batteryInfo);
|
||||||
|
|
||||||
final List<Uri> actualCardUris = mContextualCardLoader.createStaticCards().stream().map(
|
final List<Uri> actualCardUris = mContextualCardLoader.createStaticCards().stream().map(
|
||||||
ContextualCard::getSliceUri).collect(Collectors.toList());
|
ContextualCard::getSliceUri).collect(Collectors.toList());
|
||||||
@@ -90,7 +79,8 @@ public class ContextualCardLoaderTest {
|
|||||||
final String sliceUri = "contet://com.android.settings.slices/action/flashlight";
|
final String sliceUri = "contet://com.android.settings.slices/action/flashlight";
|
||||||
|
|
||||||
assertThat(
|
assertThat(
|
||||||
mContextualCardLoader.isCardEligibleToDisplay(getContextualCard(sliceUri))).isFalse();
|
mContextualCardLoader.isCardEligibleToDisplay(
|
||||||
|
getContextualCard(sliceUri))).isFalse();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@@ -98,7 +88,8 @@ public class ContextualCardLoaderTest {
|
|||||||
final String sliceUri = "content://com.android.settings.test.slices/action/flashlight";
|
final String sliceUri = "content://com.android.settings.test.slices/action/flashlight";
|
||||||
|
|
||||||
assertThat(
|
assertThat(
|
||||||
mContextualCardLoader.isCardEligibleToDisplay(getContextualCard(sliceUri))).isFalse();
|
mContextualCardLoader.isCardEligibleToDisplay(
|
||||||
|
getContextualCard(sliceUri))).isFalse();
|
||||||
}
|
}
|
||||||
|
|
||||||
private ContextualCard getContextualCard(String sliceUri) {
|
private ContextualCard getContextualCard(String sliceUri) {
|
||||||
|
@@ -20,7 +20,6 @@ package com.android.settings.homepage.contextualcards;
|
|||||||
import static com.google.common.truth.Truth.assertThat;
|
import static com.google.common.truth.Truth.assertThat;
|
||||||
|
|
||||||
import android.content.ContentResolver;
|
import android.content.ContentResolver;
|
||||||
import android.content.Context;
|
|
||||||
import android.net.Uri;
|
import android.net.Uri;
|
||||||
import android.os.Bundle;
|
import android.os.Bundle;
|
||||||
|
|
||||||
@@ -38,15 +37,13 @@ import org.robolectric.RuntimeEnvironment;
|
|||||||
@RunWith(SettingsRobolectricTestRunner.class)
|
@RunWith(SettingsRobolectricTestRunner.class)
|
||||||
public class SettingsContextualCardProviderTest {
|
public class SettingsContextualCardProviderTest {
|
||||||
|
|
||||||
private Context mContext;
|
|
||||||
private ContentResolver mResolver;
|
private ContentResolver mResolver;
|
||||||
private Uri mUri;
|
private Uri mUri;
|
||||||
private SettingsContextualCardProvider mProvider;
|
private SettingsContextualCardProvider mProvider;
|
||||||
|
|
||||||
@Before
|
@Before
|
||||||
public void setUp() {
|
public void setUp() {
|
||||||
mContext = RuntimeEnvironment.application;
|
mResolver = RuntimeEnvironment.application.getContentResolver();
|
||||||
mResolver = mContext.getContentResolver();
|
|
||||||
mUri = new Uri.Builder()
|
mUri = new Uri.Builder()
|
||||||
.scheme(ContentResolver.SCHEME_CONTENT)
|
.scheme(ContentResolver.SCHEME_CONTENT)
|
||||||
.authority(SettingsContextualCardProvider.CARD_AUTHORITY)
|
.authority(SettingsContextualCardProvider.CARD_AUTHORITY)
|
||||||
|
Reference in New Issue
Block a user