Merge "Data race in initialization of misc files info"

This commit is contained in:
Kenny Root
2011-02-24 15:09:52 -08:00
committed by Android (Google) Code Review
2 changed files with 3 additions and 3 deletions

View File

@@ -326,7 +326,7 @@ public class Memory extends SettingsPreferenceFragment implements OnCancelListen
return true; return true;
} else if (preference == mMediaPreferences[Constants.MEDIA_MISC_INDEX]) { } else if (preference == mMediaPreferences[Constants.MEDIA_MISC_INDEX]) {
Context context = getActivity().getApplicationContext(); Context context = getActivity().getApplicationContext();
if (MemoryMeasurement.getInstance(context).isSizeOfMiscCategorynonZero()) { if (MemoryMeasurement.getInstance(context).isSizeOfMiscCategoryNonZero()) {
startActivity(new Intent(context, MiscFilesHandler.class)); startActivity(new Intent(context, MiscFilesHandler.class));
} }
return true; return true;

View File

@@ -478,8 +478,8 @@ public class MemoryMeasurement {
mHandler.sendEmptyMessage(MeasurementHandler.MSG_INVALIDATE); mHandler.sendEmptyMessage(MeasurementHandler.MSG_INVALIDATE);
} }
boolean isSizeOfMiscCategorynonZero() { boolean isSizeOfMiscCategoryNonZero() {
return mFileInfoForMisc.size() > 0; return mFileInfoForMisc != null && mFileInfoForMisc.size() > 0;
} }
static class FileInfo implements Comparable<FileInfo> { static class FileInfo implements Comparable<FileInfo> {