From 11ecd1f6268b0ac39b4679f7802b90d6b3924fc3 Mon Sep 17 00:00:00 2001 From: FanWu Date: Mon, 27 Nov 2023 15:29:23 +0800 Subject: [PATCH] Ignore failing tests under connecteddevice/ Bug: 313362757 Test: atest Change-Id: Ic9c6c1f071c403c7df5d5539cc44a401ac500774 --- .../ConnectedDeviceDashboardFragmentTest.java | 2 ++ .../usb/UsbDetailsFunctionsControllerTest.java | 2 ++ .../usb/UsbDetailsPowerRoleControllerTest.java | 8 ++++++++ .../usb/UsbDetailsTranscodeMtpControllerTest.java | 6 ++++++ 4 files changed, 18 insertions(+) diff --git a/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java b/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java index 1d1f2f8fc18..5635b859fa1 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java @@ -36,6 +36,7 @@ import com.android.settings.testutils.shadow.ShadowConnectivityManager; import com.android.settings.testutils.shadow.ShadowUserManager; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -91,6 +92,7 @@ public class ConnectedDeviceDashboardFragmentTest { assertThat(indexRes.get(0).xmlResId).isEqualTo(R.xml.connected_devices); } + @Ignore("b/313362757") @Test public void nonIndexableKeys_existInXmlLayout() { final List niks = ConnectedDeviceDashboardFragment.SEARCH_INDEX_DATA_PROVIDER diff --git a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsControllerTest.java index 8257b434d2f..091abde3748 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsControllerTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsControllerTest.java @@ -44,6 +44,7 @@ import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.widget.SelectorWithWidgetPreference; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -222,6 +223,7 @@ public class UsbDetailsFunctionsControllerTest { assertThat(prefs.get(3).isChecked()).isFalse(); } + @Ignore("b/313362757") @Test public void onClickNone_mtpEnabled_shouldDisableMtp() { when(mUsbBackend.areFunctionsSupported(anyLong())).thenReturn(true); diff --git a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleControllerTest.java index e7933362c23..6be1bd58e49 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleControllerTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleControllerTest.java @@ -45,6 +45,7 @@ import com.android.settings.R; import com.android.settingslib.core.lifecycle.Lifecycle; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; @@ -100,6 +101,7 @@ public class UsbDetailsPowerRoleControllerTest { mDetailsPowerRoleController.mHandler = mHandler; } + @Ignore("b/313362757") @Test public void displayRefresh_sink_shouldUncheck() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -112,6 +114,7 @@ public class UsbDetailsPowerRoleControllerTest { assertThat(pref.isChecked()).isFalse(); } + @Ignore("b/313362757") @Test public void displayRefresh_source_shouldCheck() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -149,6 +152,7 @@ public class UsbDetailsPowerRoleControllerTest { mDetailsPowerRoleController.getPreferenceKey())).isNull(); } + @Ignore("b/313362757") @Test public void onClick_sink_shouldSetSource() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -162,6 +166,7 @@ public class UsbDetailsPowerRoleControllerTest { .isEqualTo(mContext.getString(R.string.usb_switching)); } + @Ignore("b/313362757") @Test public void onClickTwice_sink_shouldSetSourceOnce() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -176,6 +181,7 @@ public class UsbDetailsPowerRoleControllerTest { verify(mUsbBackend, times(1)).setPowerRole(POWER_ROLE_SOURCE); } + @Ignore("b/313362757") @Test public void onClickDeviceAndRefresh_success_shouldClearSubtext() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -194,6 +200,7 @@ public class UsbDetailsPowerRoleControllerTest { assertThat(pref.getSummary()).isEqualTo(""); } + @Ignore("b/313362757") @Test public void onClickDeviceAndRefresh_failed_shouldShowFailureText() { mDetailsPowerRoleController.displayPreference(mScreen); @@ -213,6 +220,7 @@ public class UsbDetailsPowerRoleControllerTest { .isEqualTo(mContext.getString(R.string.usb_switching_failed)); } + @Ignore("b/313362757") @Test public void onClickDevice_timedOut_shouldShowFailureText() { mDetailsPowerRoleController.displayPreference(mScreen); diff --git a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsTranscodeMtpControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsTranscodeMtpControllerTest.java index 7cf3ecc6dd4..51d2c1664f2 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsTranscodeMtpControllerTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDetailsTranscodeMtpControllerTest.java @@ -36,6 +36,7 @@ import androidx.preference.SwitchPreference; import com.android.settings.testutils.shadow.ShadowUtils; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -118,6 +119,7 @@ public class UsbDetailsTranscodeMtpControllerTest { assertThat(mPreference.isEnabled()).isFalse(); } + @Ignore("b/313362757") @Test public void displayRefresh_fileTransfer_withAbsentProp_shouldCheck() { mUnderTest.displayPreference(mScreen); @@ -129,6 +131,7 @@ public class UsbDetailsTranscodeMtpControllerTest { assertThat(getSwitchPreference().isChecked()).isFalse(); } + @Ignore("b/313362757") @Test public void displayRefresh_fileTransfer_withUnsetProp_shouldUncheck() { mUnderTest.displayPreference(mScreen); @@ -141,6 +144,7 @@ public class UsbDetailsTranscodeMtpControllerTest { assertThat(getSwitchPreference().isChecked()).isFalse(); } + @Ignore("b/313362757") @Test public void displayRefresh_fileTransfer_withSetProp_shouldCheck() { mUnderTest.displayPreference(mScreen); @@ -153,6 +157,7 @@ public class UsbDetailsTranscodeMtpControllerTest { assertThat(getSwitchPreference().isChecked()).isTrue(); } + @Ignore("b/313362757") @Test public void click_checked_shouldSetSystemProperty() { mUnderTest.displayPreference(mScreen); @@ -160,6 +165,7 @@ public class UsbDetailsTranscodeMtpControllerTest { assertThat(SystemProperties.getBoolean(TRANSCODE_MTP_SYS_PROP_KEY, false)).isTrue(); } + @Ignore("b/313362757") @Test public void click_unChecked_shouldUnsetSystemProperty() { mUnderTest.displayPreference(mScreen);