diff --git a/res/values/arrays.xml b/res/values/arrays.xml index 7d6745cb755..4a8d9333680 100644 --- a/res/values/arrays.xml +++ b/res/values/arrays.xml @@ -1531,12 +1531,6 @@ - - - "com.google.android.gms.persistent" - - @string/color_red diff --git a/src/com/android/settings/fuelgauge/BatteryChartPreferenceController.java b/src/com/android/settings/fuelgauge/BatteryChartPreferenceController.java index f075c7b8314..da98d2df8b1 100644 --- a/src/com/android/settings/fuelgauge/BatteryChartPreferenceController.java +++ b/src/com/android/settings/fuelgauge/BatteryChartPreferenceController.java @@ -123,10 +123,12 @@ public class BatteryChartPreferenceController extends AbstractPreferenceControll mIs24HourFormat = DateFormat.is24HourFormat(context); mNotAllowShowSummaryPackages = context.getResources() .getTextArray(R.array.allowlist_hide_summary_in_battery_usage); - mNotAllowShowEntryPackages = context.getResources() - .getTextArray(R.array.allowlist_hide_entry_in_battery_usage); mMetricsFeatureProvider = FeatureFactory.getFactory(mContext).getMetricsFeatureProvider(); + mNotAllowShowEntryPackages = + FeatureFactory.getFactory(mContext) + .getPowerUsageFeatureProvider(context) + .getHideApplicationEntries(mContext); if (lifecycle != null) { lifecycle.addObserver(this); } diff --git a/src/com/android/settings/fuelgauge/ConvertUtils.java b/src/com/android/settings/fuelgauge/ConvertUtils.java index a5a58ad2597..4794d42d95a 100644 --- a/src/com/android/settings/fuelgauge/ConvertUtils.java +++ b/src/com/android/settings/fuelgauge/ConvertUtils.java @@ -302,10 +302,10 @@ public final class ConvertUtils { private static void purgeLowPercentageAndFakeData( final Context context, final Map> indexedUsageMap) { - final List backgroundUsageTimeHideList = + final Set backgroundUsageTimeHideList = FeatureFactory.getFactory(context) .getPowerUsageFeatureProvider(context) - .getHideBackgroundUsageTimeList(context); + .getHideBackgroundUsageTimeSet(context); for (List entries : indexedUsageMap.values()) { final Iterator iterator = entries.iterator(); while (iterator.hasNext()) { diff --git a/src/com/android/settings/fuelgauge/PowerUsageFeatureProvider.java b/src/com/android/settings/fuelgauge/PowerUsageFeatureProvider.java index 39d1f5a14bf..d5fd6ee5ebe 100644 --- a/src/com/android/settings/fuelgauge/PowerUsageFeatureProvider.java +++ b/src/com/android/settings/fuelgauge/PowerUsageFeatureProvider.java @@ -24,8 +24,8 @@ import android.util.SparseIntArray; import com.android.internal.os.BatterySipper; import com.android.settingslib.fuelgauge.Estimate; -import java.util.List; import java.util.Map; +import java.util.Set; /** * Feature Provider used in power usage @@ -150,7 +150,12 @@ public interface PowerUsageFeatureProvider { Uri getBatteryHistoryUri(); /** - * Returns {@link List} for hidding applications background usage time. + * Returns {@link Set} for hidding applications background usage time. */ - List getHideBackgroundUsageTimeList(Context context); + Set getHideBackgroundUsageTimeSet(Context context); + + /** + * Returns package names for hidding application in the usage screen. + */ + CharSequence[] getHideApplicationEntries(Context context); } diff --git a/src/com/android/settings/fuelgauge/PowerUsageFeatureProviderImpl.java b/src/com/android/settings/fuelgauge/PowerUsageFeatureProviderImpl.java index 83f54a42d93..c3ca9ee843d 100644 --- a/src/com/android/settings/fuelgauge/PowerUsageFeatureProviderImpl.java +++ b/src/com/android/settings/fuelgauge/PowerUsageFeatureProviderImpl.java @@ -27,9 +27,9 @@ import com.android.internal.os.BatterySipper; import com.android.internal.util.ArrayUtils; import com.android.settingslib.fuelgauge.Estimate; -import java.util.ArrayList; -import java.util.List; +import java.util.HashSet; import java.util.Map; +import java.util.Set; public class PowerUsageFeatureProviderImpl implements PowerUsageFeatureProvider { @@ -177,7 +177,12 @@ public class PowerUsageFeatureProviderImpl implements PowerUsageFeatureProvider } @Override - public List getHideBackgroundUsageTimeList(Context context) { - return new ArrayList<>(); + public Set getHideBackgroundUsageTimeSet(Context context) { + return new HashSet<>(); + } + + @Override + public CharSequence[] getHideApplicationEntries(Context context) { + return new CharSequence[0]; } } diff --git a/tests/robotests/src/com/android/settings/fuelgauge/ConvertUtilsTest.java b/tests/robotests/src/com/android/settings/fuelgauge/ConvertUtilsTest.java index a56a8231483..ff0f25c3388 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/ConvertUtilsTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/ConvertUtilsTest.java @@ -40,6 +40,7 @@ import org.robolectric.RuntimeEnvironment; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; +import java.util.HashSet; import java.util.List; import java.util.Locale; import java.util.Map; @@ -339,8 +340,8 @@ public final class ConvertUtilsTest { "package3", "label3", 500, 5L, 3600000L, 7200000L); entryMap.put(entry.getKey(), entry); batteryHistoryMap.put(Long.valueOf(batteryHistoryKeys[2]), entryMap); - when(mPowerUsageFeatureProvider.getHideBackgroundUsageTimeList(mContext)) - .thenReturn(Arrays.asList((CharSequence) "package3")); + when(mPowerUsageFeatureProvider.getHideBackgroundUsageTimeSet(mContext)) + .thenReturn(new HashSet(Arrays.asList((CharSequence) "package3"))); final Map> purgedResultMap = ConvertUtils.getIndexedUsageMap(