From 111004958d6ebd7c6e6a5ec56cadefce6a82d175 Mon Sep 17 00:00:00 2001
From: Yi Jiang <eejiang@google.com>
Date: Fri, 11 Dec 2020 15:12:13 -0800
Subject: [PATCH] Grays out Screen Timeout Setting when disabled.

Previously we would hide the screen timeout setting when it is disabled
by admin. Instead of hide it in Display Settings, now we gray it out and
also provide the info of the enforced admin.

Bug: 174834978
Test: manually
Change-Id: Idaa3c4512eb648b67fcf6df2996c771a2f1b9617
---
 res/xml/display_settings.xml                  |  2 +-
 .../ScreenTimeoutPreferenceController.java    | 46 +++++++++++--------
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/res/xml/display_settings.xml b/res/xml/display_settings.xml
index 07564f0b1d1..8262bb29316 100644
--- a/res/xml/display_settings.xml
+++ b/res/xml/display_settings.xml
@@ -63,7 +63,7 @@
     </com.android.settingslib.RestrictedPreference>
 
     <!-- Cross-listed item, if you change this, also change it in power_usage_summary.xml -->
-    <Preference
+    <com.android.settingslib.RestrictedPreference
         android:key="screen_timeout"
         android:title="@string/screen_timeout"
         android:summary="@string/summary_placeholder"
diff --git a/src/com/android/settings/display/ScreenTimeoutPreferenceController.java b/src/com/android/settings/display/ScreenTimeoutPreferenceController.java
index 2e39e8e665a..77955ff3a98 100644
--- a/src/com/android/settings/display/ScreenTimeoutPreferenceController.java
+++ b/src/com/android/settings/display/ScreenTimeoutPreferenceController.java
@@ -26,10 +26,13 @@ import android.os.UserHandle;
 import android.os.UserManager;
 import android.provider.Settings;
 
+import androidx.preference.Preference;
+
 import com.android.settings.R;
 import com.android.settings.core.BasePreferenceController;
 import com.android.settingslib.RestrictedLockUtils;
 import com.android.settingslib.RestrictedLockUtilsInternal;
+import com.android.settingslib.RestrictedPreference;
 
 /**
  * The controller of {@link ScreenTimeoutSettings}.
@@ -43,35 +46,38 @@ public class ScreenTimeoutPreferenceController extends BasePreferenceController
 
     @Override
     public int getAvailabilityStatus() {
-        return isDisableByAdmin() ? UNSUPPORTED_ON_DEVICE : AVAILABLE;
+        return AVAILABLE;
     }
 
     @Override
-    public CharSequence getSummary() {
-        if (isDisableByAdmin()) {
-            return mContext.getString(com.android.settings.R.string.disabled_by_policy_title);
-        } else {
-            final long currentTimeout = getCurrentScreenTimeout();
-            final CharSequence[] timeoutEntries = mContext.getResources().getStringArray(
-                    R.array.screen_timeout_entries);
-            final CharSequence[] timeoutValues = mContext.getResources().getStringArray(
-                    R.array.screen_timeout_values);
-            final CharSequence description = TimeoutPreferenceController.getTimeoutDescription(
-                    currentTimeout, timeoutEntries, timeoutValues);
-            return mContext.getString(R.string.screen_timeout_summary, description);
+    public void updateState(Preference preference) {
+        final RestrictedLockUtils.EnforcedAdmin admin = getEnforcedAdmin();
+        if (admin != null) {
+            preference.setEnabled(false);
+            ((RestrictedPreference) preference).setDisabledByAdmin(admin);
         }
+        preference.setSummary(getTimeoutSummary());
     }
 
-    private boolean isDisableByAdmin() {
+    private CharSequence getTimeoutSummary() {
+        final long currentTimeout = getCurrentScreenTimeout();
+        final CharSequence[] timeoutEntries = mContext.getResources().getStringArray(
+                R.array.screen_timeout_entries);
+        final CharSequence[] timeoutValues = mContext.getResources().getStringArray(
+                R.array.screen_timeout_values);
+        final CharSequence description = TimeoutPreferenceController.getTimeoutDescription(
+                currentTimeout, timeoutEntries, timeoutValues);
+        return mContext.getString(R.string.screen_timeout_summary, description);
+    }
+
+    private RestrictedLockUtils.EnforcedAdmin getEnforcedAdmin() {
         final DevicePolicyManager dpm = mContext.getSystemService(DevicePolicyManager.class);
         if (dpm != null) {
-            final RestrictedLockUtils.EnforcedAdmin admin =
-                    RestrictedLockUtilsInternal.checkIfRestrictionEnforced(
-                            mContext, UserManager.DISALLOW_CONFIG_SCREEN_TIMEOUT,
-                            UserHandle.myUserId());
-            return admin != null;
+            return RestrictedLockUtilsInternal.checkIfRestrictionEnforced(
+                    mContext, UserManager.DISALLOW_CONFIG_SCREEN_TIMEOUT,
+                    UserHandle.myUserId());
         }
-        return false;
+        return null;
     }
 
     private long getCurrentScreenTimeout() {