Merge "Add flag to control Internet preference" into main

This commit is contained in:
Treehugger Robot
2024-04-09 08:22:57 +00:00
committed by Android (Google) Code Review
4 changed files with 14 additions and 3 deletions

View File

@@ -387,6 +387,9 @@
<!-- Whether Wi-Fi hotspot speed should be shown or not. --> <!-- Whether Wi-Fi hotspot speed should be shown or not. -->
<bool name="config_show_wifi_hotspot_speed">true</bool> <bool name="config_show_wifi_hotspot_speed">true</bool>
<!-- Whether or not Internet preference should be shown. -->
<bool name="config_show_internet_settings">true</bool>
<!-- Whether toggle_airplane is available or not. --> <!-- Whether toggle_airplane is available or not. -->
<bool name="config_show_toggle_airplane">true</bool> <bool name="config_show_toggle_airplane">true</bool>

View File

@@ -180,7 +180,7 @@ public class InternetPreferenceController extends AbstractPreferenceController i
@Override @Override
public boolean isAvailable() { public boolean isAvailable() {
return true; return mContext.getResources().getBoolean(R.bool.config_show_internet_settings);
} }
@Override @Override

View File

@@ -295,6 +295,12 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
@Override @Override
public void onCreate(Bundle icicle) { public void onCreate(Bundle icicle) {
super.onCreate(icicle); super.onCreate(icicle);
final Context context = getContext();
if (context != null && !context.getResources().getBoolean(
R.bool.config_show_internet_settings)) {
finish();
return;
}
mAirplaneModeEnabler = new AirplaneModeEnabler(getContext(), this); mAirplaneModeEnabler = new AirplaneModeEnabler(getContext(), this);
// TODO(b/37429702): Add animations and preference comparator back after initial screen is // TODO(b/37429702): Add animations and preference comparator back after initial screen is

View File

@@ -49,6 +49,7 @@ import androidx.test.annotation.UiThreadTest;
import androidx.test.core.app.ApplicationProvider; import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.android.settings.R;
import com.android.settings.testutils.ResourcesUtils; import com.android.settings.testutils.ResourcesUtils;
import com.android.settings.wifi.WifiPickerTrackerHelper; import com.android.settings.wifi.WifiPickerTrackerHelper;
import com.android.settings.wifi.WifiSummaryUpdater; import com.android.settings.wifi.WifiSummaryUpdater;
@@ -188,8 +189,9 @@ public class InternetPreferenceControllerTest {
} }
@Test @Test
public void isAvailable_shouldBeTrue() { public void isAvailable_shouldMatchPrefFlag() {
assertThat(mController.isAvailable()).isTrue(); assertThat(mController.isAvailable()).isEqualTo(
mContext.getResources().getBoolean(R.bool.config_show_internet_settings));
} }
@Test @Test