Remove the replaced activity checking to impact launching performance
Bug: 209081502 Test: make SettingsRoboTests Change-Id: Id8e2144a5965601be9c290bc4df6db0d0beb0917
This commit is contained in:
@@ -18,7 +18,6 @@ package com.android.settings.fuelgauge;
|
||||
|
||||
import android.content.ComponentName;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
|
||||
import androidx.annotation.VisibleForTesting;
|
||||
import androidx.preference.Preference;
|
||||
@@ -32,8 +31,6 @@ import com.android.settingslib.core.lifecycle.events.OnStart;
|
||||
import com.android.settingslib.core.lifecycle.events.OnStop;
|
||||
import com.android.settingslib.utils.ThreadUtils;
|
||||
|
||||
import java.util.HashMap;
|
||||
|
||||
public class TopLevelBatteryPreferenceController extends BasePreferenceController implements
|
||||
LifecycleObserver, OnStart, OnStop, BatteryPreferenceController {
|
||||
|
||||
@@ -43,13 +40,9 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle
|
||||
Preference mPreference;
|
||||
private final BatteryBroadcastReceiver mBatteryBroadcastReceiver;
|
||||
private BatteryInfo mBatteryInfo;
|
||||
private BatterySettingsFeatureProvider mBatterySettingsFeatureProvider;
|
||||
private BatteryStatusFeatureProvider mBatteryStatusFeatureProvider;
|
||||
private String mBatteryStatusLabel;
|
||||
|
||||
@VisibleForTesting
|
||||
protected static HashMap<String, ComponentName> sReplacingActivityMap = new HashMap<>();
|
||||
|
||||
public TopLevelBatteryPreferenceController(Context context, String preferenceKey) {
|
||||
super(context, preferenceKey);
|
||||
mBatteryBroadcastReceiver = new BatteryBroadcastReceiver(mContext);
|
||||
@@ -63,8 +56,6 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle
|
||||
}, true /* shortString */);
|
||||
});
|
||||
|
||||
mBatterySettingsFeatureProvider = FeatureFactory.getFactory(context)
|
||||
.getBatterySettingsFeatureProvider(context);
|
||||
mBatteryStatusFeatureProvider = FeatureFactory.getFactory(context)
|
||||
.getBatteryStatusFeatureProvider(context);
|
||||
}
|
||||
@@ -81,37 +72,6 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle
|
||||
mPreference = screen.findPreference(getPreferenceKey());
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean handlePreferenceTreeClick(Preference preference) {
|
||||
String prefFrag = preference.getFragment();
|
||||
if (prefFrag == null || prefFrag.isEmpty()) {
|
||||
// Not a redirect, so use the default.
|
||||
return super.handlePreferenceTreeClick(preference);
|
||||
}
|
||||
|
||||
ComponentName currentFragmentName = convertClassPathToComponentName(prefFrag);
|
||||
if (currentFragmentName == null) {
|
||||
return super.handlePreferenceTreeClick(preference);
|
||||
}
|
||||
|
||||
ComponentName replacingActivity;
|
||||
if (sReplacingActivityMap.containsKey(prefFrag)) {
|
||||
replacingActivity = sReplacingActivityMap.get(prefFrag);
|
||||
} else {
|
||||
replacingActivity = mBatterySettingsFeatureProvider.getReplacingActivity(
|
||||
currentFragmentName);
|
||||
sReplacingActivityMap.put(prefFrag, replacingActivity);
|
||||
}
|
||||
|
||||
if (replacingActivity == null || currentFragmentName.compareTo(replacingActivity) == 0) {
|
||||
return super.handlePreferenceTreeClick(preference);
|
||||
}
|
||||
Intent intent = new Intent();
|
||||
intent.setComponent(replacingActivity);
|
||||
mContext.startActivity(intent);
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStart() {
|
||||
mBatteryBroadcastReceiver.register();
|
||||
|
Reference in New Issue
Block a user