diff --git a/res/xml/app_and_notification.xml b/res/xml/app_and_notification.xml index 47fc3785b13..4a5ee1dda91 100644 --- a/res/xml/app_and_notification.xml +++ b/res/xml/app_and_notification.xml @@ -40,6 +40,11 @@ + + + SKIP_SYSTEM_PACKAGES = new ArraySet<>(); @@ -78,6 +80,7 @@ public class RecentAppsPreferenceController extends PreferenceController private PreferenceCategory mCategory; private Preference mSeeAllPref; + private Preference mDivider; private boolean mHasRecentApps; static { @@ -122,12 +125,14 @@ public class RecentAppsPreferenceController extends PreferenceController super.updateNonIndexableKeys(keys); // Don't index category name into search. It's not actionable. keys.add(KEY_PREF_CATEGORY); + keys.add(KEY_DIVIDER); } @Override public void displayPreference(PreferenceScreen screen) { mCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey()); mSeeAllPref = screen.findPreference(KEY_SEE_ALL); + mDivider = screen.findPreference(KEY_DIVIDER); super.displayPreference(screen); refreshUi(mCategory.getContext()); } @@ -181,6 +186,7 @@ public class RecentAppsPreferenceController extends PreferenceController private void displayOnlyAppInfo() { mCategory.setTitle(null); + mDivider.setVisible(false); mSeeAllPref.setTitle(R.string.applications_settings); mSeeAllPref.setIcon(null); int prefCount = mCategory.getPreferenceCount(); @@ -194,6 +200,7 @@ public class RecentAppsPreferenceController extends PreferenceController private void displayRecentApps(Context prefContext, List recentApps) { mCategory.setTitle(R.string.recent_app_category_title); + mDivider.setVisible(true); mSeeAllPref.setSummary(null); mSeeAllPref.setIcon(R.drawable.ic_chevron_right_24dp); diff --git a/tests/robotests/src/com/android/settings/applications/RecentAppsPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/applications/RecentAppsPreferenceControllerTest.java index c89fff85a1d..44039910850 100644 --- a/tests/robotests/src/com/android/settings/applications/RecentAppsPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/applications/RecentAppsPreferenceControllerTest.java @@ -72,6 +72,8 @@ public class RecentAppsPreferenceControllerTest { private PreferenceCategory mCategory; @Mock private Preference mSeeAllPref; + @Mock + private PreferenceCategory mDivider; @Mock(answer = Answers.RETURNS_DEEP_STUBS) private Context mMockContext; @Mock @@ -98,6 +100,8 @@ public class RecentAppsPreferenceControllerTest { when(mScreen.findPreference(RecentAppsPreferenceController.KEY_SEE_ALL)) .thenReturn(mSeeAllPref); + when(mScreen.findPreference(RecentAppsPreferenceController.KEY_DIVIDER)) + .thenReturn(mDivider); when(mCategory.getContext()).thenReturn(mContext); } @@ -112,7 +116,8 @@ public class RecentAppsPreferenceControllerTest { mController.updateNonIndexableKeys(nonIndexable); - assertThat(nonIndexable).containsExactly(mController.getPreferenceKey()); + assertThat(nonIndexable).containsAllOf(mController.getPreferenceKey(), + RecentAppsPreferenceController.KEY_DIVIDER); } @Test @@ -140,6 +145,7 @@ public class RecentAppsPreferenceControllerTest { verify(mCategory).setTitle(null); verify(mSeeAllPref).setTitle(R.string.applications_settings); verify(mSeeAllPref).setIcon(null); + verify(mDivider).setVisible(false); } @Test @@ -186,6 +192,7 @@ public class RecentAppsPreferenceControllerTest { verify(mSeeAllPref).setSummary(null); verify(mSeeAllPref).setIcon(R.drawable.ic_chevron_right_24dp); + verify(mDivider).setVisible(true); } @Test