Merge "Remove unnecessary functions from AssistGestureFeatureProvider" into oc-dr1-dev

This commit is contained in:
TreeHugger Robot
2017-06-26 20:23:09 +00:00
committed by Android (Google) Code Review
4 changed files with 1 additions and 12 deletions

View File

@@ -32,9 +32,6 @@ public interface AssistGestureFeatureProvider {
/** Returns true if the sensor is available. */ /** Returns true if the sensor is available. */
boolean isSensorAvailable(Context context); boolean isSensorAvailable(Context context);
/** Returns the resource */
int getPreferenceResourceId();
/** Returns a list of additional preference controllers */ /** Returns a list of additional preference controllers */
List<PreferenceController> getControllers(Context context, Lifecycle lifecycle); List<PreferenceController> getControllers(Context context, Lifecycle lifecycle);

View File

@@ -37,11 +37,6 @@ public class AssistGestureFeatureProviderImpl implements AssistGestureFeaturePro
return false; return false;
} }
@Override
public int getPreferenceResourceId() {
return R.xml.assist_gesture_settings;
}
@Override @Override
public List<PreferenceController> getControllers(Context context, Lifecycle lifecycle) { public List<PreferenceController> getControllers(Context context, Lifecycle lifecycle) {
return new ArrayList<>(); return new ArrayList<>();

View File

@@ -49,8 +49,7 @@ public class AssistGestureSettings extends DashboardFragment {
@Override @Override
protected int getPreferenceScreenResId() { protected int getPreferenceScreenResId() {
return FeatureFactory.getFactory(getContext()) return R.xml.assist_gesture_settings;
.getAssistGestureFeatureProvider().getPreferenceResourceId();
} }
@Override @Override

View File

@@ -57,7 +57,6 @@ public class AssistGestureSettingsTest {
@Test @Test
public void testGetPreferenceScreenResId() { public void testGetPreferenceScreenResId() {
when(mFeatureProvider.getPreferenceResourceId()).thenReturn(R.xml.assist_gesture_settings);
assertThat(mSettings.getPreferenceScreenResId()) assertThat(mSettings.getPreferenceScreenResId())
.isEqualTo(R.xml.assist_gesture_settings); .isEqualTo(R.xml.assist_gesture_settings);
} }
@@ -76,7 +75,6 @@ public class AssistGestureSettingsTest {
ShadowApplication.getInstance().getApplicationContext(), ShadowApplication.getInstance().getApplicationContext(),
true /* enabled */); true /* enabled */);
when(mFeatureProvider.getPreferenceResourceId()).thenReturn(R.xml.assist_gesture_settings);
assertThat(indexRes).isNotNull(); assertThat(indexRes).isNotNull();
assertThat(indexRes.get(0).xmlResId).isEqualTo(mSettings.getPreferenceScreenResId()); assertThat(indexRes.get(0).xmlResId).isEqualTo(mSettings.getPreferenceScreenResId());
} }