Merge "[WIFI-Enterprise] Add Server name field." into main
This commit is contained in:
@@ -126,6 +126,9 @@
|
|||||||
<PreferenceCategory
|
<PreferenceCategory
|
||||||
android:key="ip_details_category"
|
android:key="ip_details_category"
|
||||||
android:title="@string/wifi_setup_detail">
|
android:title="@string/wifi_setup_detail">
|
||||||
|
<com.android.settings.spa.preference.ComposePreference
|
||||||
|
android:key="server_name"
|
||||||
|
settings:controller="com.android.settings.wifi.details2.ServerNamePreferenceController"/>
|
||||||
<Preference
|
<Preference
|
||||||
android:key="type"
|
android:key="type"
|
||||||
android:title="@string/wifi_type_title"
|
android:title="@string/wifi_type_title"
|
||||||
|
@@ -56,6 +56,7 @@ import com.android.settings.wifi.WifiDialog2;
|
|||||||
import com.android.settings.wifi.WifiUtils;
|
import com.android.settings.wifi.WifiUtils;
|
||||||
import com.android.settings.wifi.details2.AddDevicePreferenceController2;
|
import com.android.settings.wifi.details2.AddDevicePreferenceController2;
|
||||||
import com.android.settings.wifi.details2.CertificateDetailsPreferenceController;
|
import com.android.settings.wifi.details2.CertificateDetailsPreferenceController;
|
||||||
|
import com.android.settings.wifi.details2.ServerNamePreferenceController;
|
||||||
import com.android.settings.wifi.details2.WifiAutoConnectPreferenceController2;
|
import com.android.settings.wifi.details2.WifiAutoConnectPreferenceController2;
|
||||||
import com.android.settings.wifi.details2.WifiDetailPreferenceController2;
|
import com.android.settings.wifi.details2.WifiDetailPreferenceController2;
|
||||||
import com.android.settings.wifi.details2.WifiMeteredPreferenceController2;
|
import com.android.settings.wifi.details2.WifiMeteredPreferenceController2;
|
||||||
@@ -129,6 +130,8 @@ public class WifiNetworkDetailsFragment extends RestrictedDashboardFragment impl
|
|||||||
.setWifiEntryKey(wifiEntryKey);
|
.setWifiEntryKey(wifiEntryKey);
|
||||||
use(CertificateDetailsPreferenceController.class)
|
use(CertificateDetailsPreferenceController.class)
|
||||||
.setWifiEntry(mNetworkDetailsTracker.getWifiEntry());
|
.setWifiEntry(mNetworkDetailsTracker.getWifiEntry());
|
||||||
|
use(ServerNamePreferenceController.class)
|
||||||
|
.setWifiEntry(mNetworkDetailsTracker.getWifiEntry());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -0,0 +1,56 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2024 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.wifi.details2
|
||||||
|
|
||||||
|
import android.content.Context
|
||||||
|
import android.util.Log
|
||||||
|
import androidx.compose.runtime.Composable
|
||||||
|
import androidx.compose.ui.res.stringResource
|
||||||
|
import com.android.settings.R
|
||||||
|
import com.android.settings.spa.preference.ComposePreferenceController
|
||||||
|
import com.android.settingslib.spa.widget.preference.Preference
|
||||||
|
import com.android.settingslib.spa.widget.preference.PreferenceModel
|
||||||
|
import com.android.wifi.flags.Flags
|
||||||
|
import com.android.wifitrackerlib.WifiEntry
|
||||||
|
|
||||||
|
class ServerNamePreferenceController(context: Context, preferenceKey: String) :
|
||||||
|
ComposePreferenceController(context, preferenceKey) {
|
||||||
|
|
||||||
|
private lateinit var wifiEntry: WifiEntry
|
||||||
|
|
||||||
|
fun setWifiEntry(entry: WifiEntry) {
|
||||||
|
wifiEntry = entry
|
||||||
|
}
|
||||||
|
|
||||||
|
override fun getAvailabilityStatus(): Int {
|
||||||
|
return if (Flags.androidVWifiApi() && wifiEntry.certificateInfo?.domain != null) AVAILABLE
|
||||||
|
else CONDITIONALLY_UNAVAILABLE
|
||||||
|
}
|
||||||
|
|
||||||
|
@Composable
|
||||||
|
override fun Content() {
|
||||||
|
ServerName()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Composable
|
||||||
|
fun ServerName() {
|
||||||
|
Preference(object : PreferenceModel {
|
||||||
|
override val title = stringResource(R.string.server_name_title)
|
||||||
|
override val summary = { wifiEntry.certificateInfo?.domain ?: "" }
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
@@ -0,0 +1,92 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2024 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.wifi.details2
|
||||||
|
|
||||||
|
import android.content.Context
|
||||||
|
import android.platform.test.annotations.RequiresFlagsEnabled
|
||||||
|
import androidx.compose.runtime.CompositionLocalProvider
|
||||||
|
import androidx.compose.ui.platform.LocalContext
|
||||||
|
import androidx.compose.ui.test.assertIsDisplayed
|
||||||
|
import androidx.compose.ui.test.junit4.createComposeRule
|
||||||
|
import androidx.compose.ui.test.onNodeWithText
|
||||||
|
import androidx.test.core.app.ApplicationProvider
|
||||||
|
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||||
|
import com.android.settings.R
|
||||||
|
import com.android.wifitrackerlib.WifiEntry
|
||||||
|
import org.junit.Before
|
||||||
|
import org.junit.Rule
|
||||||
|
import org.junit.Test
|
||||||
|
import org.junit.runner.RunWith
|
||||||
|
import org.mockito.kotlin.any
|
||||||
|
import org.mockito.kotlin.doNothing
|
||||||
|
import org.mockito.kotlin.doReturn
|
||||||
|
import org.mockito.kotlin.mock
|
||||||
|
import org.mockito.kotlin.spy
|
||||||
|
import org.mockito.kotlin.whenever
|
||||||
|
|
||||||
|
@RunWith(AndroidJUnit4::class)
|
||||||
|
class ServerNamePreferenceControllerTest {
|
||||||
|
@get:Rule
|
||||||
|
val composeTestRule = createComposeRule()
|
||||||
|
|
||||||
|
private val context: Context = spy(ApplicationProvider.getApplicationContext()) {
|
||||||
|
doNothing().whenever(mock).startActivity(any())
|
||||||
|
}
|
||||||
|
private val controller = ServerNamePreferenceController(context, TEST_KEY)
|
||||||
|
|
||||||
|
private val mockCertificateInfo = mock<WifiEntry.CertificateInfo> {
|
||||||
|
it.domain = DOMAIN
|
||||||
|
}
|
||||||
|
|
||||||
|
private val mockWifiEntry =
|
||||||
|
mock<WifiEntry> { on { certificateInfo } doReturn mockCertificateInfo }
|
||||||
|
|
||||||
|
@Before
|
||||||
|
fun setUp() {
|
||||||
|
controller.setWifiEntry(mockWifiEntry)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@RequiresFlagsEnabled(com.android.wifi.flags.Flags.FLAG_ANDROID_V_WIFI_API)
|
||||||
|
fun title_isDisplayed() {
|
||||||
|
composeTestRule.setContent {
|
||||||
|
CompositionLocalProvider(LocalContext provides context) {
|
||||||
|
controller.Content()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
composeTestRule.onNodeWithText(context.getString(R.string.server_name_title))
|
||||||
|
.assertIsDisplayed()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@RequiresFlagsEnabled(com.android.wifi.flags.Flags.FLAG_ANDROID_V_WIFI_API)
|
||||||
|
fun summary_isDisplayed() {
|
||||||
|
composeTestRule.setContent {
|
||||||
|
CompositionLocalProvider(LocalContext provides context) {
|
||||||
|
controller.Content()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
composeTestRule.onNodeWithText(DOMAIN).assertIsDisplayed()
|
||||||
|
}
|
||||||
|
|
||||||
|
private companion object {
|
||||||
|
const val TEST_KEY = "test_key"
|
||||||
|
const val DOMAIN = "domain"
|
||||||
|
}
|
||||||
|
}
|
Reference in New Issue
Block a user