diff --git a/res/layout/search_breadcrumb_view.xml b/res/layout/search_breadcrumb_view.xml index a78b7450fc9..08a2651c4d8 100644 --- a/res/layout/search_breadcrumb_view.xml +++ b/res/layout/search_breadcrumb_view.xml @@ -20,7 +20,7 @@ android:id="@+id/breadcrumb" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:paddingTop="8dp" + android:paddingTop="5dp" android:textAppearance="?android:attr/textAppearanceListItemSecondary" android:textColor="?android:attr/textColorSecondary" - android:ellipsize="marquee"/> \ No newline at end of file + android:ellipsize="marquee"/> diff --git a/res/layout/search_inline_switch_item.xml b/res/layout/search_inline_switch_item.xml index 75943c48d6a..526f9fdc0c6 100644 --- a/res/layout/search_inline_switch_item.xml +++ b/res/layout/search_inline_switch_item.xml @@ -46,9 +46,8 @@ android:id="@android:id/summary" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:textAppearance="?android:attr/textAppearanceListItemSecondary" - android:textColor="?android:attr/textColorSecondary" - android:maxLines="10"/> + android:singleLine="true" + android:textAppearance="?android:attr/textAppearanceListItemSecondary"/> diff --git a/res/layout/search_intent_item.xml b/res/layout/search_intent_item.xml index 31f7f26eff6..98e2a9b12df 100644 --- a/res/layout/search_intent_item.xml +++ b/res/layout/search_intent_item.xml @@ -46,9 +46,8 @@ android:id="@android:id/summary" android:layout_width="wrap_content" android:layout_height="wrap_content" + android:singleLine="true" android:textAppearance="?android:attr/textAppearanceListItemSecondary" - android:textColor="?android:attr/textColorSecondary" - android:maxLines="3" android:ellipsize="marquee"/> diff --git a/src/com/android/settings/search2/DatabaseIndexingManager.java b/src/com/android/settings/search2/DatabaseIndexingManager.java index 9a906a98a21..ccc52838b98 100644 --- a/src/com/android/settings/search2/DatabaseIndexingManager.java +++ b/src/com/android/settings/search2/DatabaseIndexingManager.java @@ -749,7 +749,6 @@ public class DatabaseIndexingManager { .setEntries(null) .setClassName(fragmentName) .setScreenTitle(screenTitle) - .setIconResId(iconResId) .setRank(rank) .setIntentAction(intentAction) .setIntentTargetPackage(intentTargetPackage) diff --git a/src/com/android/settings/search2/SearchViewHolder.java b/src/com/android/settings/search2/SearchViewHolder.java index 123a602c5c4..fef936790ed 100644 --- a/src/com/android/settings/search2/SearchViewHolder.java +++ b/src/com/android/settings/search2/SearchViewHolder.java @@ -66,9 +66,11 @@ public abstract class SearchViewHolder extends RecyclerView.ViewHolder { iconView.setImageDrawable(appResult.info.loadIcon(pm)); } else if (result.icon != null) { iconView.setImageDrawable(result.icon); + // TODO set color of icon } else { iconView.setBackgroundResource(R.drawable.empty_icon); } + bindBreadcrumbView(result); } diff --git a/tests/robotests/src/com/android/settings/search2/DatabaseIndexingManagerTest.java b/tests/robotests/src/com/android/settings/search2/DatabaseIndexingManagerTest.java index aa4e4f91931..047d867ac39 100644 --- a/tests/robotests/src/com/android/settings/search2/DatabaseIndexingManagerTest.java +++ b/tests/robotests/src/com/android/settings/search2/DatabaseIndexingManagerTest.java @@ -303,7 +303,7 @@ public class DatabaseIndexingManagerTest { // Class Name assertThat(cursor.getString(11)).isEqualTo(className); // Icon - assertThat(cursor.getInt(12)).isEqualTo(iconResId); + assertThat(cursor.getInt(12)).isEqualTo(0); // Intent Action assertThat(cursor.getString(13)).isEqualTo(action); // Target Package