From 0cc35e444bd71f117b6aed97e40ea4f3d82cd8fa Mon Sep 17 00:00:00 2001 From: Daisuke Miyakawa Date: Tue, 24 Aug 2010 15:50:43 -0700 Subject: [PATCH] Make LocalePicker Fragment. The logic calling selectFirst() is removed as - There's no comment why it is needed. - Actually SetupWizard gets stack as that forces users to see WirelessSettings in SetupWizard. The other changes: - Move back LocalePickerFragment to LocalePicker. - Make for LocalePicker in AndroidManifest - Add a short comment about how getComponent(), which should be a key for understanding how top-level settings work. - Modify LanguageSettings so that it corectly points LocalePicker as a fragment. Change-Id: I78d356e40af896ba1aab72fba12c90467371c7b0 --- AndroidManifest.xml | 7 +- proguard.flags | 1 + res/xml/language_settings.xml | 8 +- .../android/settings/LanguageSettings.java | 14 +- src/com/android/settings/LocalePicker.java | 179 +++++++++++++++- .../settings/LocalePickerFragment.java | 193 ------------------ src/com/android/settings/Settings.java | 5 + 7 files changed, 199 insertions(+), 208 deletions(-) delete mode 100644 src/com/android/settings/LocalePickerFragment.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 73d7fc44070..87311f06e3f 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -225,14 +225,17 @@ - + - + - + android:fragment="com.android.settings.LocalePicker" + android:key="phone_language" + android:title="@string/phone_language"> { + static Collator sCollator = Collator.getInstance(); + + String label; + Locale locale; + + public Loc(String label, Locale locale) { + this.label = label; + this.locale = locale; + } + + @Override + public String toString() { + return this.label; + } + + @Override + public int compareTo(Loc another) { + return sCollator.compare(this.label, another.label); + } } -} + + private void setUpLocaleList() { + final Resources resources = mActivity.getResources(); + mSpecialLocaleCodes = resources.getStringArray(R.array.special_locale_codes); + mSpecialLocaleNames = resources.getStringArray(R.array.special_locale_names); + + final String[] locales = mActivity.getAssets().getLocales(); + Arrays.sort(locales); + final int origSize = locales.length; + Loc[] preprocess = new Loc[origSize]; + int finalSize = 0; + for (int i = 0 ; i < origSize; i++ ) { + String s = locales[i]; + int len = s.length(); + if (len == 5) { + String language = s.substring(0, 2); + String country = s.substring(3, 5); + Locale l = new Locale(language, country); + + if (finalSize == 0) { + if (DEBUG) { + Log.v(TAG, "adding initial "+ toTitleCase(l.getDisplayLanguage(l))); + } + preprocess[finalSize++] = + new Loc(toTitleCase(l.getDisplayLanguage(l)), l); + } else { + // check previous entry: + // same lang and a country -> upgrade to full name and + // insert ours with full name + // diff lang -> insert ours with lang-only name + if (preprocess[finalSize-1].locale.getLanguage().equals( + language)) { + if (DEBUG) { + Log.v(TAG, "backing up and fixing "+ + preprocess[finalSize-1].label+" to "+ + getDisplayName(preprocess[finalSize-1].locale)); + } + preprocess[finalSize-1].label = toTitleCase( + getDisplayName(preprocess[finalSize-1].locale)); + if (DEBUG) { + Log.v(TAG, " and adding "+ toTitleCase(getDisplayName(l))); + } + preprocess[finalSize++] = + new Loc(toTitleCase(getDisplayName(l)), l); + } else { + String displayName; + if (s.equals("zz_ZZ")) { + displayName = "Pseudo..."; + } else { + displayName = toTitleCase(l.getDisplayLanguage(l)); + } + if (DEBUG) { + Log.v(TAG, "adding "+displayName); + } + preprocess[finalSize++] = new Loc(displayName, l); + } + } + } + } + mLocales = new Loc[finalSize]; + for (int i = 0; i < finalSize ; i++) { + mLocales[i] = preprocess[i]; + } + Arrays.sort(mLocales); + final int layoutId = R.layout.locale_picker_item; + final int fieldId = R.id.locale; + final ArrayAdapter adapter = + new ArrayAdapter(mActivity, layoutId, fieldId, mLocales); + setListAdapter(adapter); + } + + @Override + public void onActivityCreated(final Bundle savedInstanceState) { + super.onActivityCreated(savedInstanceState); + mActivity = getActivity(); + setUpLocaleList(); + } + + private static String toTitleCase(String s) { + if (s.length() == 0) { + return s; + } + + return Character.toUpperCase(s.charAt(0)) + s.substring(1); + } + + private String getDisplayName(Locale l) { + String code = l.toString(); + + for (int i = 0; i < mSpecialLocaleCodes.length; i++) { + if (mSpecialLocaleCodes[i].equals(code)) { + return mSpecialLocaleNames[i]; + } + } + + return l.getDisplayName(l); + } + + @Override + public void onResume() { + super.onResume(); + getListView().requestFocus(); + } + + @Override + public void onListItemClick(ListView l, View v, int position, long id) { + try { + IActivityManager am = ActivityManagerNative.getDefault(); + Configuration config = am.getConfiguration(); + + Loc loc = mLocales[position]; + config.locale = loc.locale; + + // indicate this isn't some passing default - the user wants this remembered + config.userSetLocale = true; + + am.updateConfiguration(config); + // Trigger the dirty bit for the Settings Provider. + BackupManager.dataChanged("com.android.providers.settings"); + } catch (RemoteException e) { + // Intentionally left blank + } + + mActivity.finish(); + } +} \ No newline at end of file diff --git a/src/com/android/settings/LocalePickerFragment.java b/src/com/android/settings/LocalePickerFragment.java deleted file mode 100644 index 08f43d8c77a..00000000000 --- a/src/com/android/settings/LocalePickerFragment.java +++ /dev/null @@ -1,193 +0,0 @@ -/* - * Copyright (C) 2010 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings; - -import android.app.Activity; -import android.app.ActivityManagerNative; -import android.app.IActivityManager; -import android.app.ListFragment; -import android.app.backup.BackupManager; -import android.content.res.Configuration; -import android.content.res.Resources; -import android.os.Bundle; -import android.os.RemoteException; -import android.util.Log; -import android.view.View; -import android.widget.ArrayAdapter; -import android.widget.ListView; - -import java.text.Collator; -import java.util.Arrays; -import java.util.Locale; - -public class LocalePickerFragment extends ListFragment { - private static final String TAG = "LocalePickerFragment"; - private static final boolean DEBUG = false; - - Loc[] mLocales; - String[] mSpecialLocaleCodes; - String[] mSpecialLocaleNames; - - Activity mActivity; - - private static class Loc implements Comparable { - static Collator sCollator = Collator.getInstance(); - - String label; - Locale locale; - - public Loc(String label, Locale locale) { - this.label = label; - this.locale = locale; - } - - @Override - public String toString() { - return this.label; - } - - @Override - public int compareTo(Loc another) { - return sCollator.compare(this.label, another.label); - } - } - - private void setUpLocaleList() { - final Resources resources = mActivity.getResources(); - mSpecialLocaleCodes = resources.getStringArray(R.array.special_locale_codes); - mSpecialLocaleNames = resources.getStringArray(R.array.special_locale_names); - - final String[] locales = mActivity.getAssets().getLocales(); - Arrays.sort(locales); - final int origSize = locales.length; - Loc[] preprocess = new Loc[origSize]; - int finalSize = 0; - for (int i = 0 ; i < origSize; i++ ) { - String s = locales[i]; - int len = s.length(); - if (len == 5) { - String language = s.substring(0, 2); - String country = s.substring(3, 5); - Locale l = new Locale(language, country); - - if (finalSize == 0) { - if (DEBUG) { - Log.v(TAG, "adding initial "+ toTitleCase(l.getDisplayLanguage(l))); - } - preprocess[finalSize++] = - new Loc(toTitleCase(l.getDisplayLanguage(l)), l); - } else { - // check previous entry: - // same lang and a country -> upgrade to full name and - // insert ours with full name - // diff lang -> insert ours with lang-only name - if (preprocess[finalSize-1].locale.getLanguage().equals( - language)) { - if (DEBUG) { - Log.v(TAG, "backing up and fixing "+ - preprocess[finalSize-1].label+" to "+ - getDisplayName(preprocess[finalSize-1].locale)); - } - preprocess[finalSize-1].label = toTitleCase( - getDisplayName(preprocess[finalSize-1].locale)); - if (DEBUG) { - Log.v(TAG, " and adding "+ toTitleCase(getDisplayName(l))); - } - preprocess[finalSize++] = - new Loc(toTitleCase(getDisplayName(l)), l); - } else { - String displayName; - if (s.equals("zz_ZZ")) { - displayName = "Pseudo..."; - } else { - displayName = toTitleCase(l.getDisplayLanguage(l)); - } - if (DEBUG) { - Log.v(TAG, "adding "+displayName); - } - preprocess[finalSize++] = new Loc(displayName, l); - } - } - } - } - mLocales = new Loc[finalSize]; - for (int i = 0; i < finalSize ; i++) { - mLocales[i] = preprocess[i]; - } - Arrays.sort(mLocales); - final int layoutId = R.layout.locale_picker_item; - final int fieldId = R.id.locale; - final ArrayAdapter adapter = - new ArrayAdapter(mActivity, layoutId, fieldId, mLocales); - setListAdapter(adapter); - } - - @Override - public void onActivityCreated(final Bundle savedInstanceState) { - super.onActivityCreated(savedInstanceState); - mActivity = getActivity(); - setUpLocaleList(); - } - - private static String toTitleCase(String s) { - if (s.length() == 0) { - return s; - } - - return Character.toUpperCase(s.charAt(0)) + s.substring(1); - } - - private String getDisplayName(Locale l) { - String code = l.toString(); - - for (int i = 0; i < mSpecialLocaleCodes.length; i++) { - if (mSpecialLocaleCodes[i].equals(code)) { - return mSpecialLocaleNames[i]; - } - } - - return l.getDisplayName(l); - } - - @Override - public void onResume() { - super.onResume(); - getListView().requestFocus(); - } - - @Override - public void onListItemClick(ListView l, View v, int position, long id) { - try { - IActivityManager am = ActivityManagerNative.getDefault(); - Configuration config = am.getConfiguration(); - - Loc loc = mLocales[position]; - config.locale = loc.locale; - - // indicate this isn't some passing default - the user wants this remembered - config.userSetLocale = true; - - am.updateConfiguration(config); - // Trigger the dirty bit for the Settings Provider. - BackupManager.dataChanged("com.android.providers.settings"); - } catch (RemoteException e) { - // Intentionally left blank - } - - mActivity.finish(); - } -} \ No newline at end of file diff --git a/src/com/android/settings/Settings.java b/src/com/android/settings/Settings.java index 9195d772ed8..460ca964423 100644 --- a/src/com/android/settings/Settings.java +++ b/src/com/android/settings/Settings.java @@ -87,6 +87,11 @@ public class Settings extends Activity if (initialFragment != null) { showFragment(initialFragment, initialArguments); } else { + // Intent#getCompontent() lets us get Fragment name, even when the Intent is + // given via . + // + // e.g. When we reach here via "ChildSetting" activity-alias, + // we should get the name here instead of targetActivity ("Settings"). if (intent.getComponent().getClassName().equals(this.getClass().getName())) { showFragment(TopLevelSettings.class.getName(), null); } else {