Fix the animation issue in DashboardSummary

1. When condition is inserted, only scroll to top when previous
position is at the top.

2. Clean condition status after it is removed. So the next time
you insert a condition view, it will always be collapsed.

Bug: 33839780
Bug: 34115341
Test: make -j40 RunSettingsRoboTests
Change-Id: I7f48524917c3119ec24b2f67ba506f381573a391
This commit is contained in:
jackqdyulei
2017-01-04 17:48:09 -08:00
parent 3d07ce6d46
commit 0bb598c4d0
4 changed files with 98 additions and 4 deletions

View File

@@ -27,7 +27,6 @@ import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
import com.android.settings.R;
import com.android.settings.SettingsActivity;
@@ -249,8 +248,11 @@ public class DashboardSummary extends InstrumentedPreferenceFragment
@Override
public void onConditionsChanged() {
Log.d(TAG, "onConditionsChanged");
final boolean scrollToTop = mLayoutManager.findFirstCompletelyVisibleItemPosition() <= 1;
mAdapter.setConditions(mConditionManager.getConditions());
mDashboard.scrollToPosition(0);
if (scrollToTop) {
mDashboard.scrollToPosition(0);
}
}
private class SuggestionLoader extends AsyncTask<Void, Void, List<Tile>> {