From e20ddfa5f4de201f07b9ad0bd1451f31b4c45d4b Mon Sep 17 00:00:00 2001 From: Yibo Wang Date: Thu, 16 Dec 2021 20:31:26 +0800 Subject: [PATCH] Add null check for mChannel object in WifiP2Settings When user switch between settings of hotspot(Enable hotspot), Internet(Enable Wifi) and Wifi-Direct(establish, disconnect and forgot P2P connection). mChannel becomes null during WiFi P2P user scenarios resulting in Settings(com.android.settings) crash on enable Wifi. This commit fixes mChannel IllegalArgumentException: Channel needs to be initialized. Test: manual test Bug: 218608961 Change-Id: I72c67bcd1086afe2aa8d2c5521107e2d38e5b0bb --- src/com/android/settings/wifi/p2p/WifiP2pSettings.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/com/android/settings/wifi/p2p/WifiP2pSettings.java b/src/com/android/settings/wifi/p2p/WifiP2pSettings.java index a926360bd9e..c1365dd752f 100644 --- a/src/com/android/settings/wifi/p2p/WifiP2pSettings.java +++ b/src/com/android/settings/wifi/p2p/WifiP2pSettings.java @@ -353,6 +353,7 @@ public class WifiP2pSettings extends DashboardFragment mWifiP2pManager.requestDeviceInfo(mChannel, WifiP2pSettings.this); mIsIgnoreInitConnectionInfoCallback = false; mWifiP2pManager.requestNetworkInfo(mChannel, networkInfo -> { + if (mChannel == null) return; mWifiP2pManager.requestConnectionInfo(mChannel, wifip2pinfo -> { if (!mIsIgnoreInitConnectionInfoCallback) { if (networkInfo.isConnected()) {