From 0a45c4099d9568341d38f03b18049f3100193c6d Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Wed, 11 Mar 2020 15:41:13 +0800 Subject: [PATCH] [Wi-Fi] Fix 2 Wi-Fi shortcuts bug Check feature flag to show the shortcut of WifiSettingsActivity or WifiSettings2Activity. Bug: 151133236 Test: manual Home context menu -> Widgets -> Settings shortcut Should only show 1 Wi-Fi shortcut option. Change-Id: Ie980b69ce1f23614475070b5c74d9a6d5cdab7ae --- .../shortcut/CreateShortcutPreferenceController.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java b/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java index c0f7e1ffc37..4843736bf57 100644 --- a/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java +++ b/src/com/android/settings/shortcut/CreateShortcutPreferenceController.java @@ -32,6 +32,7 @@ import android.graphics.drawable.Drawable; import android.graphics.drawable.Icon; import android.graphics.drawable.LayerDrawable; import android.net.ConnectivityManager; +import android.util.FeatureFlagUtils; import android.util.Log; import android.view.ContextThemeWrapper; import android.view.LayoutInflater; @@ -45,6 +46,8 @@ import androidx.preference.PreferenceGroup; import com.android.settings.R; import com.android.settings.Settings.TetherSettingsActivity; +import com.android.settings.Settings.WifiSettings2Activity; +import com.android.settings.Settings.WifiSettingsActivity; import com.android.settings.core.BasePreferenceController; import com.android.settings.overlay.FeatureFactory; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; @@ -187,6 +190,15 @@ public class CreateShortcutPreferenceController extends BasePreferenceController Log.d(TAG, "Skipping non-system app: " + info.activityInfo); continue; } + if (FeatureFlagUtils.isEnabled(mContext, FeatureFlagUtils.SETTINGS_WIFITRACKER2)) { + if (info.activityInfo.name.endsWith(WifiSettingsActivity.class.getSimpleName())) { + continue; + } + } else { + if (info.activityInfo.name.endsWith(WifiSettings2Activity.class.getSimpleName())) { + continue; + } + } shortcuts.add(info); } Collections.sort(shortcuts, SHORTCUT_COMPARATOR);