PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Settings] Code refactor - SIM slot UI preference key

Browse Source 
Avoid from controlling Preference key separately in different places.

Bug: 261374879
Test: local & auto
Change-Id: I0a777c3f2511a25e8f619deba964bc343183c3cc
This commit is contained in:
Bonian Chen
2022-12-05 09:28:59 +00:00
parent 39b4cbbc1a
commit 09bd704c45
5 changed files with 214 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusPreferenceControllerTest.java
View File

@@ -72,6 +72,7 @@ public class SimStatusPreferenceControllerTest {
private Context mContext;
private Resources mResources;
private SlotSimStatus mSlotSimStatus;
private SimStatusPreferenceController mController;
@Before
@@ -105,13 +106,13 @@ public class SimStatusPreferenceControllerTest {
final String prefKey = mController.getPreferenceKey();
when(mPreference.getKey()).thenReturn(prefKey);
when(mPreference.isVisible()).thenReturn(true);
mController.init(mFragment, SubscriptionManager.INVALID_SIM_SLOT_INDEX);
}
@Test
public void displayPreference_multiSim_shouldAddSecondPreference() {
when(mTelephonyManager.getPhoneCount()).thenReturn(2);
SlotSimStatus slotSimStatus = new SlotSimStatus(mContext);
mController.init(mFragment, slotSimStatus);
mController.displayPreference(mScreen);
@@ -121,6 +122,8 @@ public class SimStatusPreferenceControllerTest {
@Test
public void updateState_singleSim_shouldSetSingleSimTitleAndSummary() {
when(mTelephonyManager.getPhoneCount()).thenReturn(1);
SlotSimStatus slotSimStatus = new SlotSimStatus(mContext);
mController.init(mFragment, slotSimStatus);
mController.displayPreference(mScreen);
mController.updateState(mPreference);
@@ -132,6 +135,8 @@ public class SimStatusPreferenceControllerTest {
@Test
public void updateState_multiSim_shouldSetMultiSimTitleAndSummary() {
when(mTelephonyManager.getPhoneCount()).thenReturn(2);
SlotSimStatus slotSimStatus = new SlotSimStatus(mContext);
mController.init(mFragment, slotSimStatus);
mController.displayPreference(mScreen);
mController.updateState(mPreference);
@@ -149,6 +154,8 @@ public class SimStatusPreferenceControllerTest {
when(mFragment.getChildFragmentManager()).thenReturn(
mock(FragmentManager.class, Answers.RETURNS_DEEP_STUBS));
when(mTelephonyManager.getPhoneCount()).thenReturn(2);
SlotSimStatus slotSimStatus = new SlotSimStatus(mContext);
mController.init(mFragment, slotSimStatus);
mController.displayPreference(mScreen);
mController.handlePreferenceTreeClick(mFirstSimPreference);