diff --git a/res/layout/palette_listview_item.xml b/res/layout/palette_listview_item.xml index e8cc940d7f5..3342ef12f88 100644 --- a/res/layout/palette_listview_item.xml +++ b/res/layout/palette_listview_item.xml @@ -22,10 +22,12 @@ + android:paddingLeft="@dimen/accessibility_layout_margin_start_end" + android:singleLine="true" + android:textSize="14dp" /> diff --git a/res/values/dimens.xml b/res/values/dimens.xml index f79874c216d..ad5c2949fde 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -266,7 +266,7 @@ 4dp - 24dp + 16dp 18dp diff --git a/src/com/android/settings/accessibility/DaltonizerRadioButtonPreferenceController.java b/src/com/android/settings/accessibility/DaltonizerRadioButtonPreferenceController.java index dd5eb10fae4..f6f554e3db8 100644 --- a/src/com/android/settings/accessibility/DaltonizerRadioButtonPreferenceController.java +++ b/src/com/android/settings/accessibility/DaltonizerRadioButtonPreferenceController.java @@ -20,6 +20,7 @@ import android.content.ContentResolver; import android.content.Context; import android.content.res.Resources; import android.provider.Settings; +import android.view.View; import android.view.accessibility.AccessibilityManager; import androidx.lifecycle.LifecycleObserver; @@ -122,6 +123,7 @@ public class DaltonizerRadioButtonPreferenceController extends BasePreferenceCon mPreference = (RadioButtonPreference) screen.findPreference(getPreferenceKey()); mPreference.setOnClickListener(this); + mPreference.setAppendixVisibility(View.GONE); updateState(mPreference); } diff --git a/src/com/android/settings/accessibility/PaletteListPreference.java b/src/com/android/settings/accessibility/PaletteListPreference.java index de35112204c..c5c42054a64 100644 --- a/src/com/android/settings/accessibility/PaletteListPreference.java +++ b/src/com/android/settings/accessibility/PaletteListPreference.java @@ -26,7 +26,7 @@ import android.widget.ListView; import androidx.preference.Preference; import androidx.preference.PreferenceViewHolder; -import com.android.settingslib.widget.R; +import com.android.settings.R; /** Preference that easier preview by matching name to color. */ public class PaletteListPreference extends Preference { diff --git a/src/com/android/settings/accessibility/PaletteListView.java b/src/com/android/settings/accessibility/PaletteListView.java index 00308175861..ef010e2d979 100644 --- a/src/com/android/settings/accessibility/PaletteListView.java +++ b/src/com/android/settings/accessibility/PaletteListView.java @@ -35,7 +35,7 @@ import android.widget.TextView; import androidx.annotation.VisibleForTesting; -import com.android.settingslib.widget.R; +import com.android.settings.R; import com.google.common.collect.Iterables; @@ -55,13 +55,13 @@ import java.util.List; * display also the view background shows the color beside the text variable end point. */ public class PaletteListView extends ListView { - private static final float VIEW_PITCH = 0.05f; private final Context mContext; private final DisplayAdapter mDisplayAdapter; private final LayoutInflater mLayoutInflater; private final String mDefaultGradientColorCodeString; private final int mDefaultGradientColor; private float mTextBound; + private static final float LANDSCAPE_MAX_WIDTH_PERCENTAGE = 100f; public PaletteListView(Context context) { this(context, null); @@ -206,8 +206,17 @@ public class PaletteListView extends ListView { final float textWidth = textView.getPaint().measureText(textView.getText().toString()); // Computes rate of text width compare to screen width, and measures the round the double // to two decimal places manually. - final float textBound = Math.round(textWidth / getScreenWidth(windowManager) * 100) / 100f; - mTextBound = textBound + VIEW_PITCH; + final float textBound = Math.round( + textWidth / getScreenWidth(windowManager) * LANDSCAPE_MAX_WIDTH_PERCENTAGE) + / LANDSCAPE_MAX_WIDTH_PERCENTAGE; + + // Left padding and right padding with color preview. + final float paddingPixel = getResources().getDimension( + R.dimen.accessibility_layout_margin_start_end); + final float paddingWidth = + Math.round(paddingPixel / getScreenWidth(windowManager) + * LANDSCAPE_MAX_WIDTH_PERCENTAGE) / LANDSCAPE_MAX_WIDTH_PERCENTAGE; + mTextBound = textBound + paddingWidth + paddingWidth; } private static class ViewHolder {