PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix summary loader lifecycle

Browse Source 
Previous CL accidentally cleared the listening bit too early making
it never actually tell the SummaryProviders to stop listening.

Change-Id: I6af1acc861f6987b33641c40637354c75cf4d708
Fixes: 28306872
This commit is contained in:
Jason Monk
2016-04-21 14:15:13 -04:00
parent ac663d2ff5
commit 0842797a25
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/dashboard/SummaryLoader.java
View File

@@ -97,7 +97,6 @@ public class SummaryLoader {
public void setListening(boolean listening) { public void setListening(boolean listening) {
synchronized (mReceivers) { synchronized (mReceivers) {
// Unregister listeners immediately. // Unregister listeners immediately.
mListening = false;
for (int i = 0; i < mReceivers.size(); i++) { for (int i = 0; i < mReceivers.size(); i++) {
mActivity.unregisterReceiver(mReceivers.get(i)); mActivity.unregisterReceiver(mReceivers.get(i));
} }
@@ -163,7 +162,11 @@ public class SummaryLoader {
if (DEBUG) Log.d(TAG, "Listening " + listening); if (DEBUG) Log.d(TAG, "Listening " + listening);
mListening = listening; mListening = listening;
for (SummaryProvider p : mSummaryMap.keySet()) { for (SummaryProvider p : mSummaryMap.keySet()) {
try {
p.setListening(listening); p.setListening(listening);
} catch (Exception e) {
Log.d(TAG, "Problem in setListening", e);
}
} }
} }