From 796f631ff89f92ff4067a185f861cdffe1bdea70 Mon Sep 17 00:00:00 2001 From: rambowang Date: Wed, 9 Oct 2024 15:31:40 -0500 Subject: [PATCH] Clean up 24Q3 aconfig flag reset_mobile_network_settings Bug: 271921464 Test: m -j Flag: EXEMPT flag clean up Change-Id: I13f9cf25263c1465860272d5891554088e174474 --- Android.bp | 1 - src/com/android/settings/ResetNetwork.java | 14 ++++---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/Android.bp b/Android.bp index 28c3148cf28..a5025aff87e 100644 --- a/Android.bp +++ b/Android.bp @@ -107,7 +107,6 @@ android_library { "fuelgauge-protos-lite", "settings-logtags", "statslog-settings", - "telephony_flags_core_java_lib", "setupdesign-lottie-loading-layout", "device_policy_aconfig_flags_lib", "keyboard_flags_lib", diff --git a/src/com/android/settings/ResetNetwork.java b/src/com/android/settings/ResetNetwork.java index f86e29f14d1..2178b603d1b 100644 --- a/src/com/android/settings/ResetNetwork.java +++ b/src/com/android/settings/ResetNetwork.java @@ -47,7 +47,6 @@ import androidx.activity.result.contract.ActivityResultContracts; import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; -import com.android.internal.telephony.flags.Flags; import com.android.settings.core.InstrumentedFragment; import com.android.settings.core.SubSettingLauncher; import com.android.settings.network.ResetNetworkRestrictionViewBuilder; @@ -142,13 +141,10 @@ public class ResetNetwork extends InstrumentedFragment { Context context = getContext(); boolean resetSims = false; - // TODO(b/317276437) Simplify the logic once flag is released int resetOptions = ResetNetworkRequest.RESET_CONNECTIVITY_MANAGER - | ResetNetworkRequest.RESET_VPN_MANAGER; - if (Flags.resetMobileNetworkSettings()) { - resetOptions |= ResetNetworkRequest.RESET_IMS_STACK; - resetOptions |= ResetNetworkRequest.RESET_PHONE_PROCESS; - } + | ResetNetworkRequest.RESET_VPN_MANAGER + | ResetNetworkRequest.RESET_IMS_STACK + | ResetNetworkRequest.RESET_PHONE_PROCESS; ResetNetworkRequest request = new ResetNetworkRequest(resetOptions); if (mSubscriptions != null && mSubscriptions.size() > 0) { int selectedIndex = mSubscriptionSpinner.getSelectedItemPosition(); @@ -156,9 +152,7 @@ public class ResetNetwork extends InstrumentedFragment { int subId = subscription.getSubscriptionId(); request.setResetTelephonyAndNetworkPolicyManager(subId) .setResetApn(subId); - if (Flags.resetMobileNetworkSettings()) { - request.setResetImsSubId(subId); - } + request.setResetImsSubId(subId); } if (mEsimContainer.getVisibility() == View.VISIBLE && mEsimCheckbox.isChecked()) { resetSims = true;