From 89b170aa0526d13602ad64f308b38ddf514a2206 Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Wed, 3 Sep 2014 13:40:08 -0700 Subject: [PATCH] Fix bug #17374913 Accessibility settings crashes when there is no accessibility service installed - use the Preference.setSummary(CharSequence) instead of trying to set the summary manually Change-Id: I3692c50e3821a34a9c03a614cbc40209157068f3 --- .../accessibility/AccessibilitySettings.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/com/android/settings/accessibility/AccessibilitySettings.java b/src/com/android/settings/accessibility/AccessibilitySettings.java index eff5fb6de10..92c478e0211 100644 --- a/src/com/android/settings/accessibility/AccessibilitySettings.java +++ b/src/com/android/settings/accessibility/AccessibilitySettings.java @@ -513,19 +513,13 @@ public class AccessibilitySettings extends SettingsPreferenceFragment implements if (mServicesCategory.getPreferenceCount() == 0) { if (mNoServicesMessagePreference == null) { - mNoServicesMessagePreference = new Preference(getActivity()) { - @Override - protected void onBindView(View view) { - super.onBindView(view); - TextView summaryView = (TextView) view.findViewById(R.id.summary); - String title = getString(R.string.accessibility_no_services_installed); - summaryView.setText(title); - } - }; + mNoServicesMessagePreference = new Preference(getActivity()); mNoServicesMessagePreference.setPersistent(false); mNoServicesMessagePreference.setLayoutResource( R.layout.text_description_preference); mNoServicesMessagePreference.setSelectable(false); + mNoServicesMessagePreference.setSummary( + getString(R.string.accessibility_no_services_installed)); } mServicesCategory.addPreference(mNoServicesMessagePreference); }