From 08e18d624136f36a7a1dd22798d8d52abbda859c Mon Sep 17 00:00:00 2001 From: Garvita Jain Date: Tue, 25 Feb 2025 09:28:06 +0000 Subject: [PATCH] [L10n fix] Use whitespace regex for splitting string by delimiter. BUG: 387197875 Test: manual, logging Flag: EXEMPT bugfix Change-Id: Ic36257f33101d5e50496b5ca9e189efa447490f5 --- .../deviceinfo/TopLevelStoragePreferenceController.java | 2 +- .../homepage/contextualcards/slices/LowStorageSlice.java | 2 +- .../deviceinfo/TopLevelStoragePreferenceControllerTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java index 785d84a0818..a81303597e5 100644 --- a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java +++ b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java @@ -93,7 +93,7 @@ public class TopLevelStoragePreferenceController extends BasePreferenceControlle private String getSummary(long usedBytes, long totalBytes) { NumberFormat percentageFormat = NumberFormat.getPercentInstance(); final String[] freeSpace = - Formatter.formatFileSize(mContext, totalBytes - usedBytes).split(" "); + Formatter.formatFileSize(mContext, totalBytes - usedBytes).split("\\s"); return mContext.getString(R.string.storage_summary, totalBytes == 0L ? "0" : percentageFormat.format(((double) usedBytes) / totalBytes), freeSpace[0], freeSpace[1]); diff --git a/src/com/android/settings/homepage/contextualcards/slices/LowStorageSlice.java b/src/com/android/settings/homepage/contextualcards/slices/LowStorageSlice.java index 121bd82dfb1..92fa0122e4f 100644 --- a/src/com/android/settings/homepage/contextualcards/slices/LowStorageSlice.java +++ b/src/com/android/settings/homepage/contextualcards/slices/LowStorageSlice.java @@ -65,7 +65,7 @@ public class LowStorageSlice implements CustomSliceable { // Generate Low storage Slice. final String percentageString = NumberFormat.getPercentInstance().format(usedPercentage); final String[] freeSizeString = - Formatter.formatFileSize(mContext, info.freeBytes).split(" "); + Formatter.formatFileSize(mContext, info.freeBytes).split("\\s"); final ListBuilder listBuilder = new ListBuilder(mContext, CustomSliceRegistry.LOW_STORAGE_SLICE_URI, ListBuilder.INFINITY).setAccentColor( diff --git a/tests/unit/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java b/tests/unit/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java index 300d0288a8f..7b6eb5bf20c 100644 --- a/tests/unit/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java @@ -86,7 +86,7 @@ public class TopLevelStoragePreferenceControllerTest { when(mController.getStorageManagerVolumeProvider()) .thenReturn(mStorageManagerVolumeProvider); final String percentage = NumberFormat.getPercentInstance().format(1); - final String[] freeSpace = Formatter.formatFileSize(mContext, 0).split(" "); + final String[] freeSpace = Formatter.formatFileSize(mContext, 0).split("\\s"); final Preference preference = new Preference(mContext); // Wait for asynchronous thread to finish, otherwise test will flake.