From 069f926bbaf662f4429f7902915d2b9a1f438388 Mon Sep 17 00:00:00 2001 From: Liefu Liu Date: Wed, 5 Feb 2025 15:25:50 -0800 Subject: [PATCH] Update the sub title of SIM preference in Contacts Storage Setting, to be consistent with "Device-only" preference. Bug: 394335832 Test: atest ContactsStorageSettingsTest and manually test Flag: EXEMPTED (minor fix) modified: src/com/android/settings/applications/contacts/ContactsStorageSettings.java modified: tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java Change-Id: Ibf52d237da468d951211e9afa323d61fa72a1206 --- .../applications/contacts/ContactsStorageSettings.java | 2 +- .../applications/contacts/ContactsStorageSettingsTest.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/applications/contacts/ContactsStorageSettings.java b/src/com/android/settings/applications/contacts/ContactsStorageSettings.java index 4b70d465fb1..1eb6ab0aafb 100644 --- a/src/com/android/settings/applications/contacts/ContactsStorageSettings.java +++ b/src/com/android/settings/applications/contacts/ContactsStorageSettings.java @@ -232,7 +232,7 @@ public class ContactsStorageSettings extends DashboardFragment getPrefContext()); preference.setTitle(R.string.sim_card_label); preference.setIcon(R.drawable.ic_sim_card); - preference.setSummary(R.string.sim_card_label); + preference.setSummary(R.string.contacts_storage_device_only_preference_summary); preference.setKey(preferenceKey); preference.setOnClickListener(this); mAccountMap.put(preferenceKey, currentDefaultAccountAndState); diff --git a/tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java b/tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java index 0abacec1d19..e1bf87408bd 100644 --- a/tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java +++ b/tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java @@ -345,7 +345,8 @@ public class ContactsStorageSettingsTest { SelectorWithWidgetPreference simPreference = accountCategory.findPreference( String.valueOf(SIM_ACCOUNT.hashCode())); assertThat(simPreference.getTitle()).isEqualTo("SIM"); - assertThat(simPreference.getSummary()).isEqualTo("SIM"); + assertThat(simPreference.getSummary()).isEqualTo( + "Contacts may not sync or be available on your other devices"); assertThat(simPreference.getIcon()).isNotNull(); assertThat(simPreference.isChecked()).isTrue(); }