PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add private dns dialog in wifi settings

Browse Source 
This option lives in menu. A dialog will show up once this menu
is clicked.

We reuse most of the logic in go/aog/524415 with the following
updates:
1. Use radioGroup instead of directly control radioButton
2. remove bunch of methods if they are only used once.

Following cl will:
1. Remove this feature in development page
2. Add the help link at the bottom of the dialog
3. Disable "Save" button when hostname is invalid.

Bug: 68030013
Test: add for later

Change-Id: I4c6d359dc9c55675858c20e47953ef677b31c3b5
This commit is contained in:
jackqdyulei
2017-11-08 13:29:23 -08:00
parent d0965a21e4
commit 05cb931a31
8 changed files with 398 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
res/layout/private_dns_mode_dialog.xml
View File

@@ -16,6 +16,7 @@
<RadioGroup
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/private_dns_radio_group"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="8dip">
@@ -25,24 +26,21 @@
android:text="@string/private_dns_mode_off"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dip"
/>
android:layout_margin="8dip"/>
<RadioButton
android:id="@+id/private_dns_mode_opportunistic"
android:text="@string/private_dns_mode_opportunistic"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dip"
/>
android:layout_margin="8dip"/>
<RadioButton
android:id="@+id/private_dns_mode_provider"
android:text="@string/private_dns_mode_provider"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dip"
/>
android:layout_margin="8dip"/>
<EditText
android:id="@+id/private_dns_mode_provider_hostname"
@@ -52,8 +50,7 @@
android:inputType="textFilter|textUri"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip"
/>
android:layout_marginStart="40dip"
android:layout_marginEnd="8dip"/>
</RadioGroup>