From c6d5dcfc6cd7c8ff2b428693c35b2c677a2f62ab Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Mon, 5 Jul 2021 10:55:02 +0800 Subject: [PATCH] Remove no-used EntityHeaderController in Storage Settings The EntityHeaderController is a workaround to fix header shadow, however, the header shadow does not exist and it's safe to remove the EntityHeaderController. Bug: 183078080 Test: manual visual Change-Id: I5197ec62edbe7ab3ff981895ec7ff267caeb9448 --- .../settings/deviceinfo/StorageCategoryFragment.java | 10 ---------- .../settings/deviceinfo/StorageDashboardFragment.java | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/src/com/android/settings/deviceinfo/StorageCategoryFragment.java b/src/com/android/settings/deviceinfo/StorageCategoryFragment.java index 98736e39a48..4f0a5910d85 100644 --- a/src/com/android/settings/deviceinfo/StorageCategoryFragment.java +++ b/src/com/android/settings/deviceinfo/StorageCategoryFragment.java @@ -44,7 +44,6 @@ import com.android.settings.deviceinfo.storage.StorageItemPreferenceController; import com.android.settings.deviceinfo.storage.UserIconLoader; import com.android.settings.deviceinfo.storage.VolumeSizesLoader; import com.android.settings.overlay.FeatureFactory; -import com.android.settings.widget.EntityHeaderController; import com.android.settingslib.applications.StorageStatsSource; import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; @@ -161,15 +160,6 @@ public class StorageCategoryFragment extends DashboardFragment super.onAttach(context); } - @Override - public void onViewCreated(View v, Bundle savedInstanceState) { - super.onViewCreated(v, savedInstanceState); - - EntityHeaderController.newInstance(getActivity(), this /*fragment*/, - null /* header view */) - .setRecyclerView(getListView(), getSettingsLifecycle()); - } - @Override public void onResume() { super.onResume(); diff --git a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java index 6dbc3aa9a7e..c7849f9c4d4 100644 --- a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java +++ b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java @@ -56,7 +56,6 @@ import com.android.settings.deviceinfo.storage.UserIconLoader; import com.android.settings.deviceinfo.storage.VolumeSizesLoader; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settings.widget.EntityHeaderController; import com.android.settingslib.applications.StorageStatsSource; import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; @@ -320,15 +319,6 @@ public class StorageDashboardFragment extends DashboardFragment activity.invalidateOptionsMenu(); } - @Override - public void onViewCreated(View v, Bundle savedInstanceState) { - super.onViewCreated(v, savedInstanceState); - - EntityHeaderController.newInstance(getActivity(), this /*fragment*/, - null /* header view */) - .setRecyclerView(getListView(), getSettingsLifecycle()); - } - @Override public void onResume() { super.onResume();