From f05b2d22fc1202123f1981525448b5b69ff781ed Mon Sep 17 00:00:00 2001 From: Wang Han <416810799@qq.com> Date: Fri, 1 May 2020 18:25:23 +0800 Subject: [PATCH] Settings: Hide carrier settings version if empty * This gives bad UX if empty as it stays copyable and "clickable". Signed-off-by: Luca Stefani Change-Id: Ia54a1d130e77b4440753f0ce69ae1726cc2c08d9 --- .../telephony/CarrierSettingsVersionPreferenceController.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/network/telephony/CarrierSettingsVersionPreferenceController.java b/src/com/android/settings/network/telephony/CarrierSettingsVersionPreferenceController.java index a6db773d709..aec3648463e 100644 --- a/src/com/android/settings/network/telephony/CarrierSettingsVersionPreferenceController.java +++ b/src/com/android/settings/network/telephony/CarrierSettingsVersionPreferenceController.java @@ -20,6 +20,7 @@ import android.content.Context; import android.os.PersistableBundle; import android.telephony.CarrierConfigManager; import android.telephony.SubscriptionManager; +import android.text.TextUtils; import com.android.settings.core.BasePreferenceController; @@ -49,6 +50,6 @@ public class CarrierSettingsVersionPreferenceController extends BasePreferenceCo @Override public int getAvailabilityStatus() { - return AVAILABLE; + return TextUtils.isEmpty(getSummary()) ? UNSUPPORTED_ON_DEVICE : AVAILABLE; } }