From c86755bfd56ff620e740e7a99303b54350ebf164 Mon Sep 17 00:00:00 2001 From: Amith Yamasani Date: Tue, 4 Oct 2011 15:00:21 -0700 Subject: [PATCH] Handle unexpected null cursor and don't forget to close it. Bug: 5406071 Change-Id: Ia40cf7e5a3e32d6f364e787ee66580c685507571 --- src/com/android/settings/SoundSettings.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/SoundSettings.java b/src/com/android/settings/SoundSettings.java index 8b7cd37af51..f73460ba32c 100644 --- a/src/com/android/settings/SoundSettings.java +++ b/src/com/android/settings/SoundSettings.java @@ -351,8 +351,11 @@ public class SoundSettings extends SettingsPreferenceFragment implements try { Cursor cursor = context.getContentResolver().query(ringtoneUri, new String[] { MediaStore.Audio.Media.TITLE }, null, null, null); - if (cursor.moveToFirst()) { - summary = cursor.getString(0); + if (cursor != null) { + if (cursor.moveToFirst()) { + summary = cursor.getString(0); + } + cursor.close(); } } catch (SQLiteException sqle) { // Unknown title for the ringtone