From 03729e780d300da05176449c99248ab456c2575b Mon Sep 17 00:00:00 2001 From: Joel Galenson Date: Tue, 22 Jan 2019 11:19:42 -0800 Subject: [PATCH] Make links to Permissions Hub only show last day. Default to showing only the last day of accesses. Also fix a bug caused by the API changing from seconds to milliseconds. Test: Click links and see correct filter. Change-Id: I8456723a434c7144e9115e1834f48d3c1da24d4b --- .../location/RecentLocationAccessPreferenceController.java | 3 +++ .../privacy/PermissionBarChartPreferenceController.java | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/location/RecentLocationAccessPreferenceController.java b/src/com/android/settings/location/RecentLocationAccessPreferenceController.java index 2d84e21e18f..3adc489b361 100644 --- a/src/com/android/settings/location/RecentLocationAccessPreferenceController.java +++ b/src/com/android/settings/location/RecentLocationAccessPreferenceController.java @@ -13,6 +13,8 @@ */ package com.android.settings.location; +import static java.util.concurrent.TimeUnit.DAYS; + import android.Manifest; import android.content.Context; import android.content.Intent; @@ -74,6 +76,7 @@ public class RecentLocationAccessPreferenceController extends AbstractPreference final Intent intent = new Intent(Intent.ACTION_REVIEW_PERMISSION_USAGE); intent.putExtra(Intent.EXTRA_PERMISSION_NAME, Manifest.permission.ACCESS_FINE_LOCATION); + intent.putExtra(Intent.EXTRA_DURATION_MILLIS, DAYS.toMillis(1)); mContext.startActivity(intent); }); } diff --git a/src/com/android/settings/privacy/PermissionBarChartPreferenceController.java b/src/com/android/settings/privacy/PermissionBarChartPreferenceController.java index 3fac672b608..330a11d5153 100644 --- a/src/com/android/settings/privacy/PermissionBarChartPreferenceController.java +++ b/src/com/android/settings/privacy/PermissionBarChartPreferenceController.java @@ -76,6 +76,7 @@ public class PermissionBarChartPreferenceController extends BasePreferenceContro .setEmptyText(R.string.permission_bar_chart_empty_text) .setDetailsOnClickListener((View v) -> { final Intent intent = new Intent(Intent.ACTION_REVIEW_PERMISSION_USAGE); + intent.putExtra(Intent.EXTRA_DURATION_MILLIS, DAYS.toMillis(1)); mContext.startActivity(intent); }) .build(); @@ -102,7 +103,7 @@ public class PermissionBarChartPreferenceController extends BasePreferenceContro private void retrievePermissionUsageData() { mContext.getSystemService(PermissionControllerManager.class).getPermissionUsages( - false /* countSystem */, (int) DAYS.toSeconds(1), + false /* countSystem */, (int) DAYS.toMillis(1), mContext.getMainExecutor() /* executor */, this /* callback */); }