Merge "Don't set USB mode if user is a monkey"

This commit is contained in:
TreeHugger Robot
2018-02-14 02:35:10 +00:00
committed by Android (Google) Code Review
2 changed files with 18 additions and 1 deletions

View File

@@ -17,6 +17,8 @@
package com.android.settings.connecteddevice.usb; package com.android.settings.connecteddevice.usb;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils;
import android.content.Context; import android.content.Context;
import android.hardware.usb.UsbManager; import android.hardware.usb.UsbManager;
import android.support.v14.preference.PreferenceFragment; import android.support.v14.preference.PreferenceFragment;
@@ -136,10 +138,17 @@ public class UsbDetailsProfilesController extends UsbDetailsController
} else { } else {
mode &= ~thisMode; mode &= ~thisMode;
} }
mUsbBackend.setMode(mode); if (!Utils.isMonkeyRunning()) {
mUsbBackend.setMode(mode);
}
return false; return false;
} }
@Override
public boolean isAvailable() {
return !Utils.isMonkeyRunning();
}
@Override @Override
public String getPreferenceKey() { public String getPreferenceKey() {
return mKey; return mKey;

View File

@@ -36,6 +36,7 @@ import com.android.settings.TestConfig;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settings.testutils.SettingsRobolectricTestRunner; import com.android.settings.testutils.SettingsRobolectricTestRunner;
import com.android.settings.testutils.shadow.SettingsShadowResources; import com.android.settings.testutils.shadow.SettingsShadowResources;
import com.android.settings.testutils.shadow.ShadowUtils;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.google.android.collect.Lists; import com.google.android.collect.Lists;
@@ -228,6 +229,13 @@ public class UsbDetailsProfilesControllerTest {
assertThat(!switches.get(0).isChecked()); assertThat(!switches.get(0).isChecked());
} }
@Test
@Config(shadows = ShadowUtils.class)
public void testIsAvailable_isMonkey_shouldReturnFalse() {
ShadowUtils.setIsUserAMonkey(true);
assertThat(mDetailsProfilesController.isAvailable()).isFalse();
}
private List<SwitchPreference> getProfileSwitches() { private List<SwitchPreference> getProfileSwitches() {
ArrayList<SwitchPreference> result = new ArrayList<>(); ArrayList<SwitchPreference> result = new ArrayList<>();
for (int i = 0; i < mPreference.getPreferenceCount(); i++) { for (int i = 0; i < mPreference.getPreferenceCount(); i++) {