PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check euiccManager available before update EID

Browse Source 
Test: E2E & Included
Bug: 126264451
Change-Id: Ic3876567dd139819d67e8b6ddc6f2b6ba03c98fa
This commit is contained in:
Qingxi Li
2019-02-27 16:58:48 -08:00
parent 7d257171dc
commit 02f2547482
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/deviceinfo/simstatus/SimStatusDialogController.java
View File

@@ -381,7 +381,11 @@ public class SimStatusDialogController implements LifecycleObserver, OnResume, O
} }
private void updateEid() { private void updateEid() {
if (mEuiccManager.isEnabled()) {
mDialog.setText(EID_INFO_VALUE_ID, mEuiccManager.getEid()); mDialog.setText(EID_INFO_VALUE_ID, mEuiccManager.getEid());
} else {
mDialog.removeSettingFromScreen(EID_INFO_VALUE_ID);
}
} }
private void updateImsRegistrationState() { private void updateImsRegistrationState() {

12
tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogControllerTest.java
View File

@@ -124,6 +124,7 @@ public class SimStatusDialogControllerTest {
doReturn("").when(mController).getPhoneNumber(); doReturn("").when(mController).getPhoneNumber();
doReturn(mSignalStrength).when(mController).getSignalStrength(); doReturn(mSignalStrength).when(mController).getSignalStrength();
when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(""); when(mEuiccManager.getEid()).thenReturn("");
ReflectionHelpers.setField(mController, "mTelephonyManager", mTelephonyManager); ReflectionHelpers.setField(mController, "mTelephonyManager", mTelephonyManager);
ReflectionHelpers.setField(mController, "mCarrierConfigManager", mCarrierConfigManager); ReflectionHelpers.setField(mController, "mCarrierConfigManager", mCarrierConfigManager);
@@ -352,6 +353,17 @@ public class SimStatusDialogControllerTest {
mController.initialize(); mController.initialize();
verify(mDialog).setText(EID_INFO_VALUE_ID, eid); verify(mDialog).setText(EID_INFO_VALUE_ID, eid);
verify(mDialog, never()).removeSettingFromScreen(eq(EID_INFO_VALUE_ID));
}
@Test
public void initialize_showEid_euiccManagerIsNotEnabled() {
when(mEuiccManager.isEnabled()).thenReturn(false);
mController.initialize();
verify(mDialog, never()).setText(eq(EID_INFO_VALUE_ID), any());
verify(mDialog).removeSettingFromScreen(eq(EID_INFO_VALUE_ID));
} }
@Test @Test