From 01fbd9fd3ca70f7181c2421cc5f080136384737e Mon Sep 17 00:00:00 2001 From: Paul Crowley Date: Tue, 4 Nov 2014 22:51:36 +0000 Subject: [PATCH] Don't show a pattern-specific prompt at encryption time. Bug: 18054895 Change-Id: I8a029142085b9e7f59efc8e313b6438734d5a1bb --- res/values/strings.xml | 6 ------ src/com/android/settings/CredentialStorage.java | 3 +-- src/com/android/settings/CryptKeeperSettings.java | 7 ++----- src/com/android/settings/MasterClear.java | 3 +-- src/com/android/settings/MediaFormat.java | 3 +-- 5 files changed, 5 insertions(+), 17 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 7afec0b7eac..cba7cc49a3f 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2466,8 +2466,6 @@ Erase all your personal information and downloaded apps? You can\'t reverse this action! Erase everything - - Draw your unlock pattern You need to draw your unlock pattern to confirm a factory data reset. @@ -2504,8 +2502,6 @@ Erase the SD card, deleting all files stored there? You can\'t reverse this action! Erase everything - - Draw your unlock pattern You need to draw your unlock pattern to confirm that you want to erase the USB storage. @@ -4326,8 +4322,6 @@ Credentials are not available for this user - - Draw your unlock pattern You need to draw your unlock pattern to confirm credential installation. diff --git a/src/com/android/settings/CredentialStorage.java b/src/com/android/settings/CredentialStorage.java index 57b5384aa5b..2e917f56674 100644 --- a/src/com/android/settings/CredentialStorage.java +++ b/src/com/android/settings/CredentialStorage.java @@ -376,8 +376,7 @@ public final class CredentialStorage extends Activity { private boolean confirmKeyGuard() { Resources res = getResources(); boolean launched = new ChooseLockSettingsHelper(this) - .launchConfirmationActivity(CONFIRM_KEY_GUARD_REQUEST, - res.getText(R.string.credentials_install_gesture_prompt), + .launchConfirmationActivity(CONFIRM_KEY_GUARD_REQUEST, null, res.getText(R.string.credentials_install_gesture_explanation), true); return launched; diff --git a/src/com/android/settings/CryptKeeperSettings.java b/src/com/android/settings/CryptKeeperSettings.java index c5727387379..d962446da62 100644 --- a/src/com/android/settings/CryptKeeperSettings.java +++ b/src/com/android/settings/CryptKeeperSettings.java @@ -16,8 +16,6 @@ package com.android.settings; -import com.android.internal.widget.LockPatternUtils; - import android.app.Activity; import android.app.AlertDialog; import android.app.Fragment; @@ -81,7 +79,7 @@ public class CryptKeeperSettings extends Fragment { * is no keyguard available, we prompt the user to set a password. */ private Button.OnClickListener mInitiateListener = new Button.OnClickListener() { - + @Override public void onClick(View v) { if (!runKeyguardConfirmation(KEYGUARD_REQUEST)) { // TODO replace (or follow) this dialog with an explicit launch into password UI @@ -162,8 +160,7 @@ public class CryptKeeperSettings extends Fragment { return true; } - return helper.launchConfirmationActivity(request, - res.getText(R.string.master_clear_gesture_prompt), + return helper.launchConfirmationActivity(request, null, res.getText(R.string.crypt_keeper_confirm_encrypt), true); } diff --git a/src/com/android/settings/MasterClear.java b/src/com/android/settings/MasterClear.java index a2ca554253b..1c9fe5cff58 100644 --- a/src/com/android/settings/MasterClear.java +++ b/src/com/android/settings/MasterClear.java @@ -72,8 +72,7 @@ public class MasterClear extends Fragment { private boolean runKeyguardConfirmation(int request) { Resources res = getActivity().getResources(); return new ChooseLockSettingsHelper(getActivity(), this) - .launchConfirmationActivity(request, - res.getText(R.string.master_clear_gesture_prompt), + .launchConfirmationActivity(request, null, res.getText(R.string.master_clear_gesture_explanation)); } diff --git a/src/com/android/settings/MediaFormat.java b/src/com/android/settings/MediaFormat.java index dc495ec0105..20dac8e5767 100644 --- a/src/com/android/settings/MediaFormat.java +++ b/src/com/android/settings/MediaFormat.java @@ -73,8 +73,7 @@ public class MediaFormat extends Activity { */ private boolean runKeyguardConfirmation(int request) { return new ChooseLockSettingsHelper(this) - .launchConfirmationActivity(request, - getText(R.string.media_format_gesture_prompt), + .launchConfirmationActivity(request, null, getText(R.string.media_format_gesture_explanation)); }