diff --git a/res/values/strings.xml b/res/values/strings.xml index 9fe106b149a..2a8bf5b5036 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2836,7 +2836,9 @@ Camera access needed - Tap to manage permissions for Device Personalization Services + Camera access is required for screen attention. Tap to manage permissions for Device Personalization Services + + Manage permissions Prevents your screen from turning off if you\u2019re looking at it diff --git a/src/com/android/settings/display/AdaptiveSleepPermissionPreferenceController.java b/src/com/android/settings/display/AdaptiveSleepPermissionPreferenceController.java index 1110ad2b9ca..0d21e9caf80 100644 --- a/src/com/android/settings/display/AdaptiveSleepPermissionPreferenceController.java +++ b/src/com/android/settings/display/AdaptiveSleepPermissionPreferenceController.java @@ -23,11 +23,11 @@ import android.content.Intent; import android.content.pm.PackageManager; import android.net.Uri; -import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import com.android.internal.annotations.VisibleForTesting; import com.android.settings.R; +import com.android.settingslib.widget.BannerMessagePreference; /** * The controller of Screen attention's permission warning preference. The preference appears when @@ -35,8 +35,8 @@ import com.android.settings.R; */ public class AdaptiveSleepPermissionPreferenceController { @VisibleForTesting - Preference mPreference; - private PackageManager mPackageManager; + BannerMessagePreference mPreference; + private final PackageManager mPackageManager; public AdaptiveSleepPermissionPreferenceController(Context context) { final String packageName = context.getPackageManager().getAttentionServicePackageName(); @@ -44,13 +44,12 @@ public class AdaptiveSleepPermissionPreferenceController { final Intent intent = new Intent( android.provider.Settings.ACTION_APPLICATION_DETAILS_SETTINGS); intent.setData(Uri.parse("package:" + packageName)); - mPreference = new Preference(context); + mPreference = new BannerMessagePreference(context); mPreference.setTitle(R.string.adaptive_sleep_title_no_permission); mPreference.setSummary(R.string.adaptive_sleep_summary_no_permission); - mPreference.setIcon(R.drawable.ic_info_outline_24); - mPreference.setOnPreferenceClickListener(p -> { + mPreference.setPositiveButtonText(R.string.adaptive_sleep_manage_permission_button); + mPreference.setPositiveButtonOnClickListener(p -> { context.startActivity(intent); - return true; }); } diff --git a/src/com/android/settings/display/ScreenTimeoutSettings.java b/src/com/android/settings/display/ScreenTimeoutSettings.java index f9bb99ecf0d..3b0d333d5d2 100644 --- a/src/com/android/settings/display/ScreenTimeoutSettings.java +++ b/src/com/android/settings/display/ScreenTimeoutSettings.java @@ -23,7 +23,6 @@ import android.app.settings.SettingsEnums; import android.content.Context; import android.content.res.Resources; import android.graphics.drawable.Drawable; -import android.os.Bundle; import android.os.UserHandle; import android.provider.Settings; import android.text.SpannableString; @@ -39,8 +38,6 @@ import androidx.preference.PreferenceScreen; import com.android.settings.R; import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settings.search.actionbar.SearchMenuController; -import com.android.settings.support.actionbar.HelpMenuController; import com.android.settings.support.actionbar.HelpResourceProvider; import com.android.settings.widget.RadioButtonPickerFragment; import com.android.settingslib.RestrictedLockUtils; @@ -91,13 +88,6 @@ public class ScreenTimeoutSettings extends RadioButtonPickerFragment implements .getMetricsFeatureProvider(); } - @Override - public void onCreate(Bundle icicle) { - super.onCreate(icicle); - SearchMenuController.init(this /* host */); - HelpMenuController.init(this /* host */); - } - @Override public void onAttach(Context context) { super.onAttach(context);