diff --git a/res/drawable/ic_trackpad_bottom_right_click.xml b/res/drawable/ic_trackpad_bottom_right_click.xml deleted file mode 100644 index ec85830255f..00000000000 --- a/res/drawable/ic_trackpad_bottom_right_click.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - \ No newline at end of file diff --git a/res/drawable/ic_trackpad_pointer_speed.xml b/res/drawable/ic_trackpad_pointer_speed.xml deleted file mode 100644 index 128282fec94..00000000000 --- a/res/drawable/ic_trackpad_pointer_speed.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - \ No newline at end of file diff --git a/res/drawable/ic_trackpad_reverse_scrolling.xml b/res/drawable/ic_trackpad_reverse_scrolling.xml deleted file mode 100644 index a62f904300b..00000000000 --- a/res/drawable/ic_trackpad_reverse_scrolling.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - \ No newline at end of file diff --git a/res/drawable/ic_trackpad_tap_to_click.xml b/res/drawable/ic_trackpad_tap_to_click.xml deleted file mode 100644 index 7db0454935e..00000000000 --- a/res/drawable/ic_trackpad_tap_to_click.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - \ No newline at end of file diff --git a/res/drawable/ic_trackpad_touch_gestures_normal.xml b/res/drawable/ic_trackpad_touch_gestures_normal.xml deleted file mode 100644 index 34619c80432..00000000000 --- a/res/drawable/ic_trackpad_touch_gestures_normal.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - \ No newline at end of file diff --git a/res/values/strings.xml b/res/values/strings.xml index ef93ba71132..5a2a54e9b90 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4375,6 +4375,8 @@ Tap to click + + Tap dragging Touchpad gestures diff --git a/res/xml/trackpad_settings.xml b/res/xml/trackpad_settings.xml index cca92a30673..6601036073f 100644 --- a/res/xml/trackpad_settings.xml +++ b/res/xml/trackpad_settings.xml @@ -23,7 +23,6 @@ android:key="trackpad_gesture_settings" android:title="@string/trackpad_touchpad_gesture_title" android:summary="@string/trackpad_touchpad_gesture_summary" - android:icon="@drawable/ic_trackpad_touch_gestures_normal" android:order="-10" android:fragment="com.android.settings.inputmethod.TrackpadTouchGestureSettings" settings:controller="com.android.settings.inputmethod.TrackpadTouchGestureSettingsController"/> @@ -31,7 +30,6 @@ @@ -39,7 +37,6 @@ android:key="trackpad_reverse_scrolling" android:title="@string/trackpad_reverse_scrolling_title" android:summary="@string/trackpad_reverse_scrolling_summary" - android:icon="@drawable/ic_trackpad_reverse_scrolling" settings:controller="com.android.settings.inputmethod.TrackpadReverseScrollingPreferenceController" android:order="20"/> @@ -47,15 +44,20 @@ android:key="trackpad_bottom_right_tap" android:title="@string/trackpad_bottom_right_tap_title" android:summary="@string/trackpad_bottom_right_tap_summary" - android:icon="@drawable/ic_trackpad_bottom_right_click" settings:controller="com.android.settings.inputmethod.TrackpadBottomPreferenceController" android:order="30" settings:keywords="@string/keywords_trackpad_bottom_right_tap"/> + + + @@ -63,6 +65,5 @@ diff --git a/src/com/android/settings/inputmethod/TrackpadTapDraggingPreferenceController.java b/src/com/android/settings/inputmethod/TrackpadTapDraggingPreferenceController.java new file mode 100644 index 00000000000..28c2915e4d7 --- /dev/null +++ b/src/com/android/settings/inputmethod/TrackpadTapDraggingPreferenceController.java @@ -0,0 +1,53 @@ +/* + * Copyright 2024 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.inputmethod; + +import android.content.Context; +import android.hardware.input.InputSettings; + +import com.android.settings.R; +import com.android.settings.core.TogglePreferenceController; + +public class TrackpadTapDraggingPreferenceController extends TogglePreferenceController { + + public TrackpadTapDraggingPreferenceController(Context context, String key) { + super(context, key); + } + + @Override + public boolean isChecked() { + return InputSettings.useTouchpadTapDragging(mContext); + } + + @Override + public boolean setChecked(boolean isChecked) { + InputSettings.setTouchpadTapDragging(mContext, isChecked); + // TODO(b/321978150): add a metric for tap dragging settings changes. + return true; + } + + @Override + public int getAvailabilityStatus() { + return InputSettings.isTouchpadTapDraggingFeatureFlagEnabled() + ? AVAILABLE : CONDITIONALLY_UNAVAILABLE; + } + + @Override + public int getSliceHighlightMenuRes() { + return R.string.menu_key_system; + } +}