Fix post-comment in ag/27593647 to improve the readability.

Bug: 338965652
Test: atest + manual
Change-Id: I8e4c8a4508dd8c5afd1f16c6129146ba6e13bde2
This commit is contained in:
mxyyiyi
2024-06-04 11:30:47 +08:00
parent d6fe83b86e
commit 00507a47ec
2 changed files with 50 additions and 25 deletions

View File

@@ -43,7 +43,7 @@ import org.robolectric.RobolectricTestRunner
@RunWith(RobolectricTestRunner::class)
class AppOptModeSharedPreferencesUtilsTest {
@JvmField @Rule val mockitoRule: MockitoRule = MockitoJUnit.rule()
@get:Rule val mockitoRule: MockitoRule = MockitoJUnit.rule()
@Spy private var context: Context = ApplicationProvider.getApplicationContext()
@@ -62,36 +62,48 @@ class AppOptModeSharedPreferencesUtilsTest {
@Test
fun updateAppOptModeExpirationInternal_withExpirationTime_verifyData() {
insertAppOptModeEventForTest(/* expirationTime= */ 1000L)
insertAppOptModeEventForTest(expirationTime = 1000L)
val events = AppOptModeSharedPreferencesUtils.getAllEvents(context)
assertThat(events.size).isEqualTo(1)
assertAppOptimizationModeEventInfo(events.get(0), UID, PACKAGE_NAME, MODE_OPTIMIZED, 1000L)
assertThat(events).hasSize(1)
assertAppOptimizationModeEventInfo(
events[0],
UID,
PACKAGE_NAME,
MODE_OPTIMIZED,
expirationTime = 1000L
)
}
@Test
fun updateAppOptModeExpirationInternal_withoutExpirationTime_verifyEmptyList() {
insertAppOptModeEventForTest(/* expirationTime= */ UNLIMITED_EXPIRE_TIME)
insertAppOptModeEventForTest(expirationTime = UNLIMITED_EXPIRE_TIME)
assertThat(AppOptModeSharedPreferencesUtils.getAllEvents(context)).isEmpty()
}
@Test
fun deleteAppOptimizationModeEventByUid_uidNotContained_verifyData() {
insertAppOptModeEventForTest(/* expirationTime= */ 1000L)
assertThat(AppOptModeSharedPreferencesUtils.getAllEvents(context).size).isEqualTo(1)
insertAppOptModeEventForTest(expirationTime = 1000L)
assertThat(AppOptModeSharedPreferencesUtils.getAllEvents(context)).hasSize(1)
AppOptModeSharedPreferencesUtils.deleteAppOptimizationModeEventByUid(context, UNSET_UID)
val events = AppOptModeSharedPreferencesUtils.getAllEvents(context)
assertThat(events.size).isEqualTo(1)
assertAppOptimizationModeEventInfo(events.get(0), UID, PACKAGE_NAME, MODE_OPTIMIZED, 1000L)
assertThat(events).hasSize(1)
assertAppOptimizationModeEventInfo(
events[0],
UID,
PACKAGE_NAME,
MODE_OPTIMIZED,
expirationTime = 1000L
)
}
@Test
fun deleteAppOptimizationModeEventByUid_uidExisting_verifyData() {
insertAppOptModeEventForTest(/* expirationTime= */ 1000L)
insertAppOptModeEventForTest(expirationTime = 1000L)
AppOptModeSharedPreferencesUtils.deleteAppOptimizationModeEventByUid(context, UID)
@@ -100,20 +112,32 @@ class AppOptModeSharedPreferencesUtilsTest {
@Test
fun resetExpiredAppOptModeBeforeTimestamp_noExpiredData_verifyData() {
insertAppOptModeEventForTest(/* expirationTime= */ 1000L)
insertAppOptModeEventForTest(expirationTime = 1000L)
AppOptModeSharedPreferencesUtils.resetExpiredAppOptModeBeforeTimestamp(context, 999L)
AppOptModeSharedPreferencesUtils.resetExpiredAppOptModeBeforeTimestamp(
context,
queryTimestampMs = 999L
)
val events = AppOptModeSharedPreferencesUtils.getAllEvents(context)
assertThat(events.size).isEqualTo(1)
assertAppOptimizationModeEventInfo(events.get(0), UID, PACKAGE_NAME, MODE_OPTIMIZED, 1000L)
assertThat(events).hasSize(1)
assertAppOptimizationModeEventInfo(
events[0],
UID,
PACKAGE_NAME,
MODE_OPTIMIZED,
expirationTime = 1000L
)
}
@Test
fun resetExpiredAppOptModeBeforeTimestamp_hasExpiredData_verifyEmptyList() {
insertAppOptModeEventForTest(/* expirationTime= */ 1000L)
insertAppOptModeEventForTest(expirationTime = 1000L)
AppOptModeSharedPreferencesUtils.resetExpiredAppOptModeBeforeTimestamp(context, 1001L)
AppOptModeSharedPreferencesUtils.resetExpiredAppOptModeBeforeTimestamp(
context,
queryTimestampMs = 1001L
)
assertThat(AppOptModeSharedPreferencesUtils.getAllEvents(context)).isEmpty()
}
@@ -185,7 +209,7 @@ class AppOptModeSharedPreferencesUtilsTest {
mutableListOf(UID),
mutableListOf(PACKAGE_NAME),
mutableListOf(MODE_OPTIMIZED),
longArrayOf(expirationTime)
longArrayOf(expirationTime),
) { _: Int, _: String ->
testBatteryOptimizeUtils
}