Check the results from applypatch in PerformCommandDiff; and abort the
update on failure.
Bug:29339536
Change-Id: I5087d79ba532b54250f4c17560524255c8a4fabc
am: 894176632c
* commit '894176632c7295875d01cfdc273b706996c483a4':
Call ioctl before each write on retry
Change-Id: I814e7c9409d94aed8733a9e1fc562394f8da1e76
If the update is a retry, ioctl(BLKDISCARD) the destination blocks before
writing to these blocks.
Bug: 28990135
Change-Id: I1e703808e68ebb1292cd66afd76be8fd6946ee59
Write error code, cause code, and retry count into last_install. So we
can have more information about the reason of a failed OTA.
Example of new last_install:
@/cache/recovery/block.map package name
0 install result
retry: 1 retry count (new)
error: 30 error code (new)
cause: 12 error cause (new)
Details in:
go/android-ota-errorcode
Bug: 28471955
Change-Id: I00e7153c821e7355c1be81a86c7f228108f3dc37
am: fb5d7f6172
* commit 'fb5d7f6172f88a9e26ef554ef56717798f83522d':
Add time and I/O info to last_install
Change-Id: I3e80f862aff97a2fbbd2324cbbc5d16aede196f3
am: 027b403e8a
* commit '027b403e8aa90ddc533e39e623df09fc319bb6ee':
Add time and I/O info to last_install
Change-Id: I04c368dd551946427f683df906eb42e0f2f740e9
am: dd874b1c87
* commit 'dd874b1c87eb04f28db0db2629df0adde568a74c':
Add time and I/O info to last_install
Change-Id: I02aa858d5ce488d3acbf5400811e2565cf7d9c75
Remove O_SYNC from mzExtractRecursive() and PackageExtractFileFn().
These functions deal with extracting whole files from the update
package onto a filesystem. If run on ext4 on a rotating disk, for
example, the O_SYNC flag will cause serious performance problems
and the extraction proecss can take over 30 minutes, with no
obvious benefits.
This API function already calls fsync(fd) after each file is
extracted to ensure data and metadata is written to the underlying
block device, so the O_SYNC calls should be superfluous and safely
removable.
This change does not affect the OTA patch paths or any modification
of the bootloader partition or writes to other 'emmc' partitions.
Signed-off-by: Alistair Strachan <alistair.strachan@imgtec.com>
Change-Id: I9cbb98a98e6278bf5c0d7efaae340773d1fbfcd2
am: 187e7c7
* commit '187e7c7ab027af90409371fd08386e6d1c2eac3b':
updater: Don't zero out CommandParameters with memset(3).
Change-Id: I0e894b103a5c1a43a24177707fc1190764c1ea45
[1] switched a few things to android::base::unique_fd including
CommandParameters.fd. However, we were using memset(3) to zero out the
struct, which effectively assigned unique_fd(0) to fd. When it called
fd.reset(), file descriptor 0 was unintentionally closed. When FD 0 was
later reassigned via open(2), it led to lseek(2) errors: "Bad file
descriptor".
This CL switches to using braced-init (i.e. '= {}') instead, so that the
default constructor unique_fd(-1) would be called.
[1]: commit bcabd09293
Bug: 28391985
Change-Id: If1f99932b15552714c399e65c8b80550344b758a
am: 6e2a8b1
* commit '6e2a8b11ecb0bdfd6f4a2f096519075663a2d1c2':
Convert recovery to use BoringSSL instead of mincrypt.
Change-Id: Ief6b279d1e7fd00af4e8153ac29212343493b293
Currently block_image_verify() stashes source blocks to /cache and
in some case triggers I/O errors. To avoid this risk, We create
a map from the hash value to the source blocks' range_set. When
executing stash command in verify mode, source range is saved but block
contents aren't stashed. And load_stash could get its value from
either the stashed file from the previous update, or the contents on
the source partition specified by the saved range.
Bug: 27584487
Bug: 25633753
Change-Id: I775baf4bee55762b6e7b204f8294afc597afd996
(cherry picked from commit 0188935d55)
Currently block_image_verify() stashes source blocks to /cache and
in some case triggers I/O errors. To avoid this risk, We create
a map from the hash value to the source blocks' range_set. When
executing stash command in verify mode, source range is saved but block
contents aren't stashed. And load_stash could get its value from
either the stashed file from the previous update, or the contents on
the source partition specified by the saved range.
Bug: 27584487
Bug: 25633753
Change-Id: I775baf4bee55762b6e7b204f8294afc597afd996
am: 6f44637
* commit '6f446373fdda9e084e7cce86c4694f365e75951b':
Revert "DO NOT MERGE Control fault injection with config files instead of build flags"
Elliott Hughes
Tianjie Xu
Tao Bao
Alistair Strachan
Chih-hung Hsieh
Mattias Nissler
Jed Estep