Mount system as read-only by default

Mounting system as rw can prevent future OTA updates. The purpose
of this patch set is to prevent TWRP from mounting sytem as rw on
the first boot. Device maintainers should update their twrp.fstab
files on these devices to include an additional line:
/system_image emmc /dev/block/../system

This line will allow TWRP to create a raw system image backup to
ensure that the user can return to an original state for future
OTA updates.

Change-Id: I8929d85bc3a5b96cc564bc7f734b58d5612ec833
This commit is contained in:
Ethan Yonker
2015-05-27 09:22:49 -05:00
parent f746dbb054
commit eb32b1ff00
13 changed files with 459 additions and 7 deletions
+54
View File
@@ -196,6 +196,8 @@ GUIAction::GUIAction(xml_node<>* node)
ADD_ACTION(startmtp);
ADD_ACTION(stopmtp);
ADD_ACTION(cancelbackup);
ADD_ACTION(checkpartitionlifetimewrites);
ADD_ACTION(mountsystemtoggle);
// remember actions that run in the caller thread
for (mapFunc::const_iterator it = mf.begin(); it != mf.end(); ++it)
@@ -1737,3 +1739,55 @@ int GUIAction::getKeyByName(std::string key)
return atol(key.c_str());
}
int GUIAction::checkpartitionlifetimewrites(std::string arg)
{
int op_status = 0;
TWPartition* sys = PartitionManager.Find_Partition_By_Path(arg);
operation_start("Check Partition Lifetime Writes");
if (sys) {
if (sys->Check_Lifetime_Writes() != 0)
DataManager::SetValue("tw_lifetime_writes", 1);
else
DataManager::SetValue("tw_lifetime_writes", 0);
op_status = 0; // success
} else {
DataManager::SetValue("tw_lifetime_writes", 1);
op_status = 1; // fail
}
operation_end(op_status);
return 0;
}
int GUIAction::mountsystemtoggle(std::string arg)
{
int op_status = 0;
bool remount_system = PartitionManager.Is_Mounted_By_Path("/system");
operation_start("Toggle System Mount");
if (!PartitionManager.UnMount_By_Path("/system", true)) {
op_status = 1; // fail
} else {
TWPartition* Part = PartitionManager.Find_Partition_By_Path("/system");
if (Part) {
if (DataManager::GetIntValue("tw_mount_system_ro")) {
DataManager::SetValue("tw_mount_system_ro", 0);
Part->Change_Mount_Read_Only(false);
} else {
DataManager::SetValue("tw_mount_system_ro", 1);
Part->Change_Mount_Read_Only(true);
}
if (remount_system) {
Part->Mount(true);
}
op_status = 0; // success
} else {
op_status = 1; // fail
}
}
operation_end(op_status);
return 0;
}