Merge "Recovery now expects public keys in zipfile"

This commit is contained in:
Tianjie Xu
2018-10-23 02:40:55 +00:00
committed by Gerrit Code Review
+5 -5
View File
@@ -695,18 +695,18 @@ int install_package(const std::string& path, bool* wipe_cache, bool needs_mount,
} }
bool verify_package(const unsigned char* package_data, size_t package_size) { bool verify_package(const unsigned char* package_data, size_t package_size) {
static constexpr const char* PUBLIC_KEYS_FILE = "/res/keys"; static constexpr const char* CERTIFICATE_ZIP_FILE = "/system/etc/security/otacerts.zip";
std::vector<Certificate> loadedKeys; std::vector<Certificate> loaded_keys = LoadKeysFromZipfile(CERTIFICATE_ZIP_FILE);
if (!load_keys(PUBLIC_KEYS_FILE, loadedKeys)) { if (loaded_keys.empty()) {
LOG(ERROR) << "Failed to load keys"; LOG(ERROR) << "Failed to load keys";
return false; return false;
} }
LOG(INFO) << loadedKeys.size() << " key(s) loaded from " << PUBLIC_KEYS_FILE; LOG(INFO) << loaded_keys.size() << " key(s) loaded from " << CERTIFICATE_ZIP_FILE;
// Verify package. // Verify package.
ui->Print("Verifying update package...\n"); ui->Print("Verifying update package...\n");
auto t0 = std::chrono::system_clock::now(); auto t0 = std::chrono::system_clock::now();
int err = verify_file(package_data, package_size, loadedKeys, int err = verify_file(package_data, package_size, loaded_keys,
std::bind(&RecoveryUI::SetProgress, ui, std::placeholders::_1)); std::bind(&RecoveryUI::SetProgress, ui, std::placeholders::_1));
std::chrono::duration<double> duration = std::chrono::system_clock::now() - t0; std::chrono::duration<double> duration = std::chrono::system_clock::now() - t0;
ui->Print("Update package verification took %.1f s (result %d).\n", duration.count(), err); ui->Print("Update package verification took %.1f s (result %d).\n", duration.count(), err);