udpater: Call fsync() after rename().
We need to ensure the renamed filename reaches the underlying storage.
Bug: 22840552
Change-Id: I824b6e9d8a9c5966035be7b42a73678d07376342
(cherry picked from commit dc3922622a)
This commit is contained in:
@@ -19,6 +19,7 @@
|
|||||||
#include <dirent.h>
|
#include <dirent.h>
|
||||||
#include <fcntl.h>
|
#include <fcntl.h>
|
||||||
#include <inttypes.h>
|
#include <inttypes.h>
|
||||||
|
#include <libgen.h>
|
||||||
#include <pthread.h>
|
#include <pthread.h>
|
||||||
#include <stdarg.h>
|
#include <stdarg.h>
|
||||||
#include <stdio.h>
|
#include <stdio.h>
|
||||||
@@ -632,6 +633,7 @@ static int WriteStash(const char* base, const char* id, int blocks, uint8_t* buf
|
|||||||
char *cn = NULL;
|
char *cn = NULL;
|
||||||
int fd = -1;
|
int fd = -1;
|
||||||
int rc = -1;
|
int rc = -1;
|
||||||
|
int dfd = -1;
|
||||||
int res;
|
int res;
|
||||||
struct stat st;
|
struct stat st;
|
||||||
|
|
||||||
@@ -690,6 +692,20 @@ static int WriteStash(const char* base, const char* id, int blocks, uint8_t* buf
|
|||||||
goto wsout;
|
goto wsout;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const char* dname;
|
||||||
|
dname = dirname(cn);
|
||||||
|
dfd = TEMP_FAILURE_RETRY(open(dname, O_RDONLY | O_DIRECTORY));
|
||||||
|
|
||||||
|
if (dfd == -1) {
|
||||||
|
fprintf(stderr, "failed to open \"%s\" failed: %s\n", dname, strerror(errno));
|
||||||
|
goto wsout;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (fsync(dfd) == -1) {
|
||||||
|
fprintf(stderr, "fsync \"%s\" failed: %s\n", dname, strerror(errno));
|
||||||
|
goto wsout;
|
||||||
|
}
|
||||||
|
|
||||||
rc = 0;
|
rc = 0;
|
||||||
|
|
||||||
wsout:
|
wsout:
|
||||||
@@ -697,6 +713,10 @@ wsout:
|
|||||||
close(fd);
|
close(fd);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (dfd != -1) {
|
||||||
|
close(dfd);
|
||||||
|
}
|
||||||
|
|
||||||
if (fn) {
|
if (fn) {
|
||||||
free(fn);
|
free(fn);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user