PawletOS/android_bootable_recovery
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge \\\"Fix clang-tidy performance warnings.\\\" am: 2a3b695168 am: 977903da49

Browse Source 
am: fc7cbe465f

Change-Id: I06aef6bf6f2865b2b33f90bf539118c39118b09c
This commit is contained in:
Chih-Hung Hsieh
2016-07-27 20:56:02 +00:00
committed by android-build-merger
parent 8281767f34 fc7cbe465f
commit b32823b7e7
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
minui/events.cpp
+1 -1
View File
@@ -204,7 +204,7 @@ int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data) {
return 0; return 0;
} }
void ev_iterate_available_keys(std::function<void(int)> f) { void ev_iterate_available_keys(const std::function<void(int)>& f) {
// Use unsigned long to match ioctl's parameter type. // Use unsigned long to match ioctl's parameter type.
unsigned long ev_bits[BITS_TO_LONGS(EV_MAX)]; // NOLINT unsigned long ev_bits[BITS_TO_LONGS(EV_MAX)]; // NOLINT
unsigned long key_bits[BITS_TO_LONGS(KEY_MAX)]; // NOLINT unsigned long key_bits[BITS_TO_LONGS(KEY_MAX)]; // NOLINT
minui/minui.h
+1 -1
View File
@@ -67,7 +67,7 @@ typedef int (*ev_set_key_callback)(int code, int value, void* data);
int ev_init(ev_callback input_cb, void* data); int ev_init(ev_callback input_cb, void* data);
void ev_exit(); void ev_exit();
int ev_add_fd(int fd, ev_callback cb, void* data); int ev_add_fd(int fd, ev_callback cb, void* data);
void ev_iterate_available_keys(std::function<void(int)> f); void ev_iterate_available_keys(const std::function<void(int)>& f);
int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data); int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data);
// 'timeout' has the same semantics as poll(2). // 'timeout' has the same semantics as poll(2).
otafault/ota_io.cpp
+1 -1
View File
@@ -30,7 +30,7 @@ static std::string read_fault_file_name = "";
static std::string write_fault_file_name = ""; static std::string write_fault_file_name = "";
static std::string fsync_fault_file_name = ""; static std::string fsync_fault_file_name = "";
static bool get_hit_file(const char* cached_path, std::string ffn) { static bool get_hit_file(const char* cached_path, const std::string& ffn) {
return should_hit_cache() return should_hit_cache()
? !strncmp(cached_path, OTAIO_CACHE_FNAME, strlen(cached_path)) ? !strncmp(cached_path, OTAIO_CACHE_FNAME, strlen(cached_path))
: !strncmp(cached_path, ffn.c_str(), strlen(cached_path)); : !strncmp(cached_path, ffn.c_str(), strlen(cached_path));
recovery-refresh.cpp
+1 -1
View File
@@ -76,7 +76,7 @@ static ssize_t logrotate(
} }
std::string name(filename); std::string name(filename);
size_t dot = name.find_last_of("."); size_t dot = name.find_last_of('.');
std::string sub = name.substr(0, dot); std::string sub = name.substr(0, dot);
if (!strstr(LAST_KMSG_FILE, sub.c_str()) && if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&
recovery.cpp
+1 -1
View File
@@ -1446,7 +1446,7 @@ static ssize_t logrotate(
} }
std::string name(filename); std::string name(filename);
size_t dot = name.find_last_of("."); size_t dot = name.find_last_of('.');
std::string sub = name.substr(0, dot); std::string sub = name.substr(0, dot);
if (!strstr(LAST_KMSG_FILE, sub.c_str()) && if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&