PawletOS/android_bootable_recovery
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Use flags = 0 to avoid fd closing for child updater process"

Browse Source
This commit is contained in:
Bill Peckham
2019-03-29 13:41:40 +00:00
committed by Gerrit Code Review
parent a0fe1227b8 08ba1ad9b1
commit 50bda24f1e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
install.cpp
+3 -1
View File
@@ -342,7 +342,9 @@ static int try_update_binary(const std::string& package, ZipArchiveHandle zip, b
// The updater in child process writes to the pipe to communicate with recovery. // The updater in child process writes to the pipe to communicate with recovery.
android::base::unique_fd pipe_read, pipe_write; android::base::unique_fd pipe_read, pipe_write;
if (!android::base::Pipe(&pipe_read, &pipe_write)) { // Explicitly disable O_CLOEXEC using 0 as the flags (last) parameter to Pipe
// so that the child updater process will recieve a non-closed fd.
if (!android::base::Pipe(&pipe_read, &pipe_write, 0)) {
PLOG(ERROR) << "Failed to create pipe for updater-recovery communication"; PLOG(ERROR) << "Failed to create pipe for updater-recovery communication";
return INSTALL_CORRUPT; return INSTALL_CORRUPT;
} }