Restore default umask after forking for update-binary.

A system/core change made in Mar 26 2012 6ebf12f "init: Change umask
of forked processes to 077" changed the default umask of services
forked from init.

Because recovery is forked from init, it has a umask of 077. Therefore
when update-binary is forked from recovery, it too has a umask of 077.

This umask is overly restrictive and can cause problems for scripts
relying on minzip to extract binaries directly into the target
filesystem. Any directories updated by minzip will have their
permissions reset to r-x------ and created files will have similarly
restrictive permissions.

As it seems unlikely this security measure was intended to have this
side effect on legacy sideloads that do not have chmods to repair
the damage done by minzip, this change reverts the umask to 022 in
the fork made for update-binary.

Change-Id: Ib1a3fc83aa4ecc7480b5d0c00f3c7d0d040d4887

This commit is contained in:

Alistair Strachan

2013-07-17 10:41:49 -07:00

committed by

Doug Zongker

parent 9690e2b370

commit 027429a34f

1 changed files with 1 additions and 0 deletions

									
										install.cpp
									
		+1
		
												View File
												
				@@ -120,6 +120,7 @@ try_update_binary(const char *path, ZipArchive *zip, int* wipe_cache) {

				    pid_t pid = fork();

				    if (pid == 0) {

				        umask(022);

				        close(pipefd[0]);

				        execv(binary, (char* const*)args);

				        fprintf(stdout, "E:Can't run %s (%s)\n", binary, strerror(errno));