PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Don't trigger getRecentTasks() calls when waiting for an old call

Browse Source 
TaskbarRecentAppsController#reloadRecentTasksIfNeeded() triggers a call
to fetch Recents tasks, that call is expensive as it goes through WM
Shell and the system server. If we trigger reloadRecentTasksIfNeeded()
multiple times we're queueing up multiple calls to fetch Recents tasks.

With this CL we avoid queueing up multiple calls, and instead just make
one new call when the old one finishes. That way we can only ever have
one call getRecentTasks() call triggered through
reloadRecentTasksIfNeeded() posted at any one time.

Bug: 415090968
Flag: com.android.window.flags.enable_taskbar_recent_tasks_throttle_bugfix
Test: TaskbarRecentAppsControllerTest
Change-Id: I58b66e4564af4e64837317a9de7be398395d8568
This commit is contained in:
Gustav Sennton
2025-05-14 13:28:51 +00:00
parent 894224b3d2
commit ffa5c2ad83
2 changed files with 130 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quickstep/src/com/android/launcher3/taskbar/TaskbarRecentAppsController.kt
+39 -17
View File
@@ -16,6 +16,8 @@
package com.android.launcher3.taskbar
import android.content.Context
import android.util.Log
import android.window.DesktopExperienceFlags
import android.window.DesktopModeFlags
import androidx.annotation.VisibleForTesting
import com.android.launcher3.BubbleTextView.RunningAppState
@@ -57,6 +59,9 @@ class TaskbarRecentAppsController(
}
}
val enableRecentTasksThrottle =
DesktopExperienceFlags.ENABLE_TASKBAR_RECENT_TASKS_THROTTLE_BUGFIX.isTrue
// TODO(b/343532825): Add a setting to disable Recents even when the flag is on.
var canShowRecentApps = enableRecentsInTaskbar()
@VisibleForTesting
@@ -175,6 +180,11 @@ class TaskbarRecentAppsController(
// tasks again if we have already requested it and the task list has not changed
private var taskListChangeId = -1
// Whether we're currently loading recents tasks
private var loadingRecentsTasks = false
// Whether we need to reload recents tasks when the current loading operation is finished
private var needsRecentsTasksReload = false
// Whether we've loaded recents tasks at least once
private var recentTasksLoaded = false
fun init(taskbarControllers: TaskbarControllers, previousShownTasks: List<GroupTask>) {
@@ -240,24 +250,34 @@ class TaskbarRecentAppsController(
}
private fun reloadRecentTasksIfNeeded() {
if (!recentsModel.isTaskListValid(taskListChangeId)) {
taskListChangeId =
recentsModel.getTasks(RecentsFilterState.EMPTY_FILTER) { tasks ->
recentTasksLoaded = true
allRecentTasks = tasks
val oldRunningTaskdIds = runningTaskIds
val oldMinimizedTaskIds = minimizedTaskIds
desktopTasks =
allRecentTasks.filterIsInstance<DesktopTask>().flatMap { it.tasks }
val runningTasksChanged = oldRunningTaskdIds != runningTaskIds
val minimizedTasksChanged = oldMinimizedTaskIds != minimizedTaskIds
if (
onRecentsOrHotseatChanged() || runningTasksChanged || minimizedTasksChanged
) {
controllers.taskbarViewController.commitRunningAppsToUI()
}
}
if (recentsModel.isTaskListValid(taskListChangeId)) return
if (enableRecentTasksThrottle && loadingRecentsTasks) {
Log.v(TAG, "reloadRecentTasksIfNeeded: tried to reload while loading recents tasks")
needsRecentsTasksReload = true
return
}
Log.v(TAG, "reloadRecentTasksIfNeeded: load recents tasks")
// Only indicate that recents tasks are loading if the enableRecentTasksThrottle flag is on
loadingRecentsTasks = enableRecentTasksThrottle
taskListChangeId =
recentsModel.getTasks(RecentsFilterState.EMPTY_FILTER) { tasks ->
loadingRecentsTasks = false
recentTasksLoaded = true
allRecentTasks = tasks
val oldRunningTaskdIds = runningTaskIds
val oldMinimizedTaskIds = minimizedTaskIds
desktopTasks = allRecentTasks.filterIsInstance<DesktopTask>().flatMap { it.tasks }
val runningTasksChanged = oldRunningTaskdIds != runningTaskIds
val minimizedTasksChanged = oldMinimizedTaskIds != minimizedTaskIds
if (onRecentsOrHotseatChanged() || runningTasksChanged || minimizedTasksChanged) {
controllers.taskbarViewController.commitRunningAppsToUI()
}
if (needsRecentsTasksReload) {
Log.v(TAG, "reloadRecentTasksIfNeeded: reload recents tasks")
needsRecentsTasksReload = false
reloadRecentTasksIfNeeded()
}
}
}
/**
@@ -462,6 +482,8 @@ class TaskbarRecentAppsController(
get() = tasks.map { task -> task.key.packageName }
private companion object {
private val TAG = "TaskbarRecentAppsController"
const val MAX_RECENT_TASKS = 2
}
}