diff --git a/build.gradle b/build.gradle index b5eeeb0709..6620c10012 100644 --- a/build.gradle +++ b/build.gradle @@ -40,7 +40,6 @@ android { androidTest { java.srcDirs = ['tests/src'] - res.srcDirs = ['tests/res'] manifest.srcFile "tests/AndroidManifest.xml" } } diff --git a/src/com/android/launcher3/LauncherProvider.java b/src/com/android/launcher3/LauncherProvider.java index 47ceb8c6e7..207121b274 100644 --- a/src/com/android/launcher3/LauncherProvider.java +++ b/src/com/android/launcher3/LauncherProvider.java @@ -527,13 +527,8 @@ public class LauncherProvider extends ContentProvider { private long mMaxScreenId = -1; DatabaseHelper(Context context, LauncherProvider provider) { - super(new NoLocaleSqliteContext(context), LauncherFiles.LAUNCHER_DB, - null, DATABASE_VERSION); - mContext = context; - mProvider = provider; - - mAppWidgetHost = new AppWidgetHost(context, Launcher.APPWIDGET_HOST_ID); - + this(context, provider, LauncherFiles.LAUNCHER_DB, + new AppWidgetHost(context, Launcher.APPWIDGET_HOST_ID)); // Table creation sometimes fails silently, which leads to a crash loop. // This way, we will try to create a table every time after crash, so the device // would eventually be able to recover. @@ -544,6 +539,21 @@ public class LauncherProvider extends ContentProvider { addWorkspacesTable(getWritableDatabase(), true); } + initIds(); + } + + /** + * Constructor used only in tests. + */ + public DatabaseHelper( + Context context, LauncherProvider provider, String tableName, AppWidgetHost host) { + super(new NoLocaleSqliteContext(context), tableName, null, DATABASE_VERSION); + mContext = context; + mProvider = provider; + mAppWidgetHost = host; + } + + protected void initIds() { // In the case where neither onCreate nor onUpgrade gets called, we read the maxId from // the DB here if (mMaxItemId == -1) { @@ -554,19 +564,6 @@ public class LauncherProvider extends ContentProvider { } } - /** - * Constructor used only in tests. - */ - public DatabaseHelper(Context context, LauncherProvider provider, String tableName) { - super(new NoLocaleSqliteContext(context), tableName, null, DATABASE_VERSION); - mContext = context; - mProvider = provider; - - mAppWidgetHost = null; - mMaxItemId = initializeMaxItemId(getWritableDatabase()); - mMaxScreenId = initializeMaxScreenId(getWritableDatabase()); - } - private boolean tableExists(String tableName) { Cursor c = getReadableDatabase().query( true, "sqlite_master", new String[] {"tbl_name"}, diff --git a/tests/Android.mk b/tests/Android.mk index d82f0b35c6..0c4b5ff1f4 100644 --- a/tests/Android.mk +++ b/tests/Android.mk @@ -16,13 +16,10 @@ LOCAL_PATH := $(call my-dir) include $(CLEAR_VARS) -src_dirs := src LOCAL_MODULE_TAGS := tests LOCAL_STATIC_JAVA_LIBRARIES := android-support-test ub-uiautomator LOCAL_SRC_FILES := $(call all-java-files-under, src) -LOCAL_RESOURCE_DIR := $(addprefix $(LOCAL_PATH)/, $(res_dirs)) -LOCAL_AAPT_FLAGS := --auto-add-overlay LOCAL_SDK_VERSION := 23 diff --git a/tests/AndroidManifest.xml b/tests/AndroidManifest.xml index 8acc5e90cd..afe8952979 100644 --- a/tests/AndroidManifest.xml +++ b/tests/AndroidManifest.xml @@ -20,12 +20,14 @@ - + diff --git a/tests/res/values/string.xml b/tests/res/values/string.xml deleted file mode 100644 index 3c1ec5c610..0000000000 --- a/tests/res/values/string.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - Dummy string for tests. - - diff --git a/tests/src/com/android/launcher3/BindWidgetTest.java b/tests/src/com/android/launcher3/BindWidgetTest.java index 06e193640a..4e8881cf01 100644 --- a/tests/src/com/android/launcher3/BindWidgetTest.java +++ b/tests/src/com/android/launcher3/BindWidgetTest.java @@ -109,7 +109,7 @@ public class BindWidgetTest extends InstrumentationTestCase { public void testUnboundWidget_removed() throws Exception { LauncherAppWidgetProviderInfo info = findWidgetProvider(false); LauncherAppWidgetInfo item = createWidgetInfo(info, false); - item.appWidgetId = 33; + item.appWidgetId = -33; // Since there is no widget to verify, just wait until the workspace is ready. setupAndVerifyContents(item, Workspace.class, null); @@ -253,6 +253,7 @@ public class BindWidgetTest extends InstrumentationTestCase { runTestOnUiThread(new Runnable() { @Override public void run() { + LauncherClings.markFirstRunClingDismissed(mTargetContext); ManagedProfileHeuristic.markExistingUsersForNoFolderCreation(mTargetContext); LauncherAppState.getInstance().getModel().resetLoadedState(true, true); } diff --git a/tests/src/com/android/launcher3/util/TestLauncherProvider.java b/tests/src/com/android/launcher3/util/TestLauncherProvider.java index aef3240ca8..a11013ffe9 100644 --- a/tests/src/com/android/launcher3/util/TestLauncherProvider.java +++ b/tests/src/com/android/launcher3/util/TestLauncherProvider.java @@ -26,7 +26,8 @@ public class TestLauncherProvider extends LauncherProvider { private static class MyDatabaseHelper extends DatabaseHelper { public MyDatabaseHelper(Context context, LauncherProvider provider) { - super(context, provider, null); + super(context, provider, null, null); + initIds(); } @Override