From b453ef76212b31cd20075242108726b393d14fdb Mon Sep 17 00:00:00 2001 From: Jon Miranda Date: Mon, 25 Jan 2021 15:30:26 -0500 Subject: [PATCH] Fix bug where dragview gets stuck on screen. * Since the BubbleTextViews views do not have a listener, the long press was still getting triggered even though it was in a pressed state. * We only trigger long press if the view is not pressed or if there is no listener. * A listener is only added for widgets, and for long press wiidgets are not pressed state. Bug: 162636845 Test: manual test, repo steps in bug Change-Id: Ia9df12cf31a0844403d69ddacebf2bdbc5c59d3b (cherry picked from commit 6fa63473e197e0abf6664a3899555019a829e119) --- src/com/android/launcher3/CheckLongPressHelper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/launcher3/CheckLongPressHelper.java b/src/com/android/launcher3/CheckLongPressHelper.java index ff405ece3e..c707df04c0 100644 --- a/src/com/android/launcher3/CheckLongPressHelper.java +++ b/src/com/android/launcher3/CheckLongPressHelper.java @@ -115,7 +115,7 @@ public class CheckLongPressHelper { private void triggerLongPress() { if ((mView.getParent() != null) && mView.hasWindowFocus() - && (!mView.isPressed() || mListener == null) + && (!mView.isPressed() || mListener != null) && !mHasPerformedLongPress) { boolean handled; if (mListener != null) {