From ef08582d368f8fc59907cb5d3f45237199e93b7f Mon Sep 17 00:00:00 2001 From: Liran Binyamin Date: Thu, 11 Jul 2024 11:59:51 -0400 Subject: [PATCH] Fix regression in bubble animation This was a bug introduced in ag/28230638. Accidentally passed the wrong boolean value. The bug is that the initial state animation does not play, and the bubble bar remains invisible. Flag: com.android.wm.shell.enable_bubble_bar Fixes: 352119655 Fixes: 352412093 Test: manual - Clear all bubbles - Send initial bubble - Observe that the initial state animation plays correctly Change-Id: Ie1435539e348c0a92a11db0b58a0b3bce6525cc0 --- .../launcher3/taskbar/bubbles/BubbleBarViewController.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java index ad815094bb..0f9de16ee0 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java @@ -400,7 +400,7 @@ public class BubbleBarViewController { addedBubble.getView().setOnClickListener(mBubbleClickListener); mBubbleDragController.setupBubbleView(addedBubble.getView()); if (!suppressAnimation) { - animateBubbleNotification(addedBubble, isExpanding, /* isUpdate= */ true); + animateBubbleNotification(addedBubble, isExpanding, /* isUpdate= */ false); } } @@ -428,7 +428,7 @@ public class BubbleBarViewController { } return; } - animateBubbleNotification(bubble, isExpanding, /* isUpdate= */ true); + animateBubbleNotification(bubble, isExpanding, /* isUpdate= */ false); } else { Log.w(TAG, "addBubble, bubble was null!"); }