From 3f314e5a07d617d3923477999a1a5a3969757ff3 Mon Sep 17 00:00:00 2001 From: Alex Chau Date: Thu, 10 Apr 2025 21:53:02 +0100 Subject: [PATCH] Mark all PerDisplayRepository as LauncherAppSingleton - Without this annotation, everytime the PerDisplayRepository is requested, a new PerDisplayRepository is created effectively not functioning as a repositroy. - This caused RotationTouchHelper to be created whenever get() is called, thus losing its state across the swipe gesture Fix: 409722063 Fix: 409258907 Test: manual Flag: EXEMPT bug fix Change-Id: Ibde4c6ce18b96bafea1c40d8c69a4552f371501a --- .../src/com/android/launcher3/dagger/PerDisplayModule.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/quickstep/src/com/android/launcher3/dagger/PerDisplayModule.kt b/quickstep/src/com/android/launcher3/dagger/PerDisplayModule.kt index 3bef6ca284..def588ccd9 100644 --- a/quickstep/src/com/android/launcher3/dagger/PerDisplayModule.kt +++ b/quickstep/src/com/android/launcher3/dagger/PerDisplayModule.kt @@ -52,6 +52,7 @@ interface BasePerDisplayModule { @Module object PerDisplayRepositoriesModule { @Provides + @LauncherAppSingleton fun provideRecentsAnimationDeviceStateRepo( repositoryFactory: PerDisplayInstanceRepositoryImpl.Factory, rotationTouchHelperRepository: PerDisplayRepository, @@ -77,6 +78,7 @@ object PerDisplayRepositoriesModule { } @Provides + @LauncherAppSingleton fun provideTaskAnimationManagerRepo( repositoryFactory: PerDisplayInstanceRepositoryImpl.Factory, instanceFactory: TaskAnimationManager.Factory, @@ -92,6 +94,7 @@ object PerDisplayRepositoriesModule { } @Provides + @LauncherAppSingleton fun provideRotationTouchHandlerRepo( repositoryFactory: PerDisplayInstanceRepositoryImpl.Factory, @DisplayContext displayContextRepository: PerDisplayRepository, @@ -113,6 +116,7 @@ object PerDisplayRepositoriesModule { } @Provides + @LauncherAppSingleton @DisplayContext fun provideDisplayContext( repositoryFactory: PerDisplayInstanceRepositoryImpl.Factory,