From c3993d15d9a2d5a4643faa44ac10a12667429b5e Mon Sep 17 00:00:00 2001 From: Winson Chung Date: Tue, 14 Jan 2014 10:30:27 -0800 Subject: [PATCH 1/2] Properly saving migration cling keys. Change-Id: Id52a12da6af0fc91463dae07bbeb355ee04873d0 (cherry picked from commit 285b6e1483fd7ddc941fb2c9c50d43ee1b1841ca) --- src/com/android/launcher3/LauncherClings.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/com/android/launcher3/LauncherClings.java b/src/com/android/launcher3/LauncherClings.java index 541eaddd0d..85937aa62e 100644 --- a/src/com/android/launcher3/LauncherClings.java +++ b/src/com/android/launcher3/LauncherClings.java @@ -373,14 +373,14 @@ class LauncherClings { showMigrationWorkspaceCling(); } }; - dismissCling(cling, cb, WORKSPACE_CLING_DISMISSED_KEY, + dismissCling(cling, cb, MIGRATION_CLING_DISMISSED_KEY, DISMISS_CLING_DURATION, true); } }; mLauncher.getWorkspace().post(dismissCb); } - private void dismissAnyWorkspaceCling(Cling cling, View v) { + private void dismissAnyWorkspaceCling(Cling cling, String key, View v) { Runnable cb = null; if (v == null) { cb = new Runnable() { @@ -389,8 +389,7 @@ class LauncherClings { } }; } - dismissCling(cling, cb, WORKSPACE_CLING_DISMISSED_KEY, - DISMISS_CLING_DURATION, true); + dismissCling(cling, cb, key, DISMISS_CLING_DURATION, true); // Fade in the search bar mLauncher.getSearchBar().showSearchBar(true); @@ -428,12 +427,12 @@ class LauncherClings { public void dismissMigrationWorkspaceCling(View v) { Cling cling = (Cling) mLauncher.findViewById(R.id.migration_workspace_cling); - dismissAnyWorkspaceCling(cling, v); + dismissAnyWorkspaceCling(cling, MIGRATION_WORKSPACE_CLING_DISMISSED_KEY, v); } public void dismissWorkspaceCling(View v) { Cling cling = (Cling) mLauncher.findViewById(R.id.workspace_cling); - dismissAnyWorkspaceCling(cling, v); + dismissAnyWorkspaceCling(cling, WORKSPACE_CLING_DISMISSED_KEY, v); } public void dismissFolderCling(View v) { From 930514df0529ff5316bb00f3e45a4de036b7f5aa Mon Sep 17 00:00:00 2001 From: Adam Cohen Date: Thu, 16 Jan 2014 16:07:50 -0800 Subject: [PATCH 2/2] Fix overlapping pages (issue 12551580) Change-Id: I03c29c36828b6c4baadb33b13b0e852b07b2d40f (cherry picked from commit efb31e399d335351a8db3de54ed66fabd30606ba) --- src/com/android/launcher3/DeviceProfile.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/launcher3/DeviceProfile.java b/src/com/android/launcher3/DeviceProfile.java index 8bcf6c32e0..7ca4f811c2 100644 --- a/src/com/android/launcher3/DeviceProfile.java +++ b/src/com/android/launcher3/DeviceProfile.java @@ -557,7 +557,7 @@ public class DeviceProfile { // In portrait, we want the pages spaced such that there is no // overhang of the previous / next page into the current page viewport. // We assume symmetrical padding in portrait mode. - return 2 * getWorkspacePadding().left; + return Math.max(defaultPageSpacingPx, 2 * getWorkspacePadding().left); } }